Skip to content

fix(internet): filter banned dots from email addresses#1883

Merged
ST-DDT merged 9 commits intonextfrom
fix/email-address-dots
Mar 8, 2023
Merged

fix(internet): filter banned dots from email addresses#1883
ST-DDT merged 9 commits intonextfrom
fix/email-address-dots

Conversation

@matthewmayer
Copy link
Copy Markdown
Contributor

@matthewmayer matthewmayer commented Feb 28, 2023

fix #1882

@matthewmayer matthewmayer requested a review from a team as a code owner February 28, 2023 09:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #1883 (35c78c9) into next (4f14533) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1883      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2356     2356              
  Lines      236563   236570       +7     
  Branches     1196     1194       -2     
==========================================
- Hits       235695   235693       -2     
- Misses        846      855       +9     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/internet/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 91.71% <0.00%> (-2.67%) ⬇️

@matthewmayer matthewmayer changed the title fix (internet): dont allow email addresses with . at ends or .. in middle fix(internet): dont allow email addresses with . at ends or .. in middle Feb 28, 2023
@ejcheng ejcheng added c: bug Something isn't working m: internet Something is referring to the internet module labels Feb 28, 2023
ST-DDT
ST-DDT reviewed Feb 28, 2023
View reviewed changes
Comment thread src/modules/internet/index.ts
Comment thread test/internet.spec.ts Outdated
Comment thread test/internet.spec.ts Outdated
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug p: 1-normal Nothing urgent labels Feb 28, 2023
Matt Mayer and others added 2 commits March 1, 2023 17:35
Shinigami92
Shinigami92 previously approved these changes Mar 1, 2023
View reviewed changes
Comment thread src/modules/internet/index.ts Outdated
Comment thread src/modules/internet/index.ts Outdated
@Shinigami92
Update src/modules/internet/index.ts
c55ffc4 
Co-authored-by: Shinigami <chrissi92@hotmail.de>
@Shinigami92
Update src/modules/internet/index.ts
31eb0f6 
Co-authored-by: Shinigami <chrissi92@hotmail.de>
ST-DDT
ST-DDT reviewed Mar 3, 2023
View reviewed changes
Comment thread test/internet.spec.ts Outdated
Comment thread test/internet.spec.ts Outdated
ST-DDT
ST-DDT requested changes Mar 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@ST-DDT
Copy link
Copy Markdown
Member

ST-DDT commented Mar 5, 2023

Thank you for fixing this.

@ST-DDT ST-DDT requested review from a team and Shinigami92 March 5, 2023 08:44
@ST-DDT ST-DDT changed the title fix(internet): dont allow email addresses with . at ends or .. in middle fix(internet): filter banned dots from email addresses Mar 8, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) March 8, 2023 21:44
@ST-DDT ST-DDT merged commit f8926c7 into next Mar 8, 2023
@Shinigami92 Shinigami92 deleted the fix/email-address-dots branch March 9, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels

c: bug Something isn't working m: internet Something is referring to the internet module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Projects

No open projects
Faker Roadmap
Status: Done

Milestone

v8.x

Development

Successfully merging this pull request may close these issues.

email address local part shouldnt start or end with .

5 participants

@matthewmayer @ST-DDT @Shinigami92 @xDivisionByZerox @ejcheng