Skip to content

fix(helpers): uniform distribution in helpers.arrayElements#1770

Merged
ST-DDT merged 8 commits intonextfrom
fix/helpers/arrayElements-uniform-distribution
Jan 24, 2023
Merged

fix(helpers): uniform distribution in helpers.arrayElements#1770
ST-DDT merged 8 commits intonextfrom
fix/helpers/arrayElements-uniform-distribution

Conversation

@ST-DDT
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT commented Jan 23, 2023

@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: helpers Something is referring to the helpers module labels Jan 23, 2023
@ST-DDT ST-DDT requested review from a team January 23, 2023 14:36
@ST-DDT ST-DDT self-assigned this Jan 23, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (next@3a44d5f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 63f915d differs from pull request most recent head d49df45. Consider uploading reports for the commit d49df45 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1770   +/-   ##
=======================================
  Coverage        ?   99.64%           
=======================================
  Files           ?     2340           
  Lines           ?   242625           
  Branches        ?     1103           
=======================================
  Hits            ?   241773           
  Misses          ?      831           
  Partials        ?       21

@ST-DDT ST-DDT mentioned this pull request Jan 23, 2023
Closed
@ST-DDT
Copy link
Copy Markdown
Member Author

ST-DDT commented Jan 23, 2023

FFR: https://jsben.ch/1w9rg

xDivisionByZerox
xDivisionByZerox reviewed Jan 23, 2023
View reviewed changes
Comment thread test/helpers.spec.ts Outdated
@ST-DDT
Copy link
Copy Markdown
Member Author

ST-DDT commented Jan 23, 2023

The new tests show that the measured results are off by less then 20/1000 from the expectation.
(Increased the error margin in the tests a bit to reduce the likelihood of errors)

@ST-DDT ST-DDT requested review from a team and Shinigami92 January 23, 2023 20:18
Shinigami92
Shinigami92 reviewed Jan 23, 2023
View reviewed changes
Comment thread test/helpers.spec.ts Outdated
Comment thread test/helpers.spec.ts Outdated
@ST-DDT ST-DDT requested review from a team, Shinigami92 and xDivisionByZerox January 23, 2023 20:51
@ST-DDT ST-DDT requested a review from a team January 23, 2023 21:58
@ST-DDT ST-DDT enabled auto-merge (squash) January 24, 2023 21:52
@ST-DDT ST-DDT merged commit 2b84b33 into next Jan 24, 2023
@ST-DDT ST-DDT deleted the fix/helpers/arrayElements-uniform-distribution branch January 24, 2023 22:01
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
@ST-DDT @matthewmayer
fix(helpers): uniform distribution in helpers.arrayElements (faker-js…
4c29f42 
…#1770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels

c: bug Something isn't working m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Projects

No open projects
Faker Roadmap
Status: Done

Milestone

v8.x

Development

Successfully merging this pull request may close these issues.

Uniform distribution in helpers.arrayElements results

3 participants

@ST-DDT @Shinigami92 @xDivisionByZerox