feat(number): add binary and octal random number generation#1708
Conversation
ST-DDT
left a comment
There was a problem hiding this comment.
Could you please move the methods above the hex method so that the methods are a bit more in order.
Binary(2), Octal(8), Hex(16)
Should we also create these methods in the stri g module to generate them in a specific length?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1708 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2249 2249
Lines 240424 240482 +58
Branches 1079 1083 +4
=======================================
+ Hits 239549 239607 +58
Misses 854 854
Partials 21 21
|
Sure, will reorder the methods. Should I create another PR to add them in the string module as well ? |
Yes, I think that would be the easiest solution. |
Shinigami92
left a comment
There was a problem hiding this comment.
Please solve @ST-DDT suggestions, but already a good-to-go from my side
This PR implements binary and octal random number generation.
Issue: #184
PR that implements this feature in string module: #1710