fix(locale): filter inappropriate words in the en locale

[rcfox]

Addressing #1631

[ST-DDT]

IMO the English locale is big enough that we can be quite thoroughly with the removals.
Some of the words don't feel offending by themselves, but I agree, that they might cause irritation even by unawareness of their (original) meaning. (Especially when mixed with random words e.g. any adjective+color.)

[ST-DDT]

Team decision

We will check:

• each of your suggested removals once your PR is complete, for some we aren't sure yet, but the general direction is good
• the en locale for additional entries that needs to be removed
• whether there are list's of words in the internet that can be considered offensive/unprofessional and use it for additional filtering

[rcfox]

This PR is ready for review now. I do realize I probably went a little overboard on some of the words, so it's unlikely I'll have any arguments about words to reinstate. (With such long lists, I sort of had to turn part of my brain off and go by a gut feeling.)

I did initially try a using a list of bad words meant for moderation software, but felt they lacked nuance.

[ST-DDT]

Please run pnpm run test -u to update the test snapshots.

[rcfox]

Rebased on latest 'next' branch. Updated test snapshots. Squashed the commits into a single commit.

[codecov]

Codecov Report

Merging #1633 (80e33c3) into next (d7ccd70) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff            @@
##             next    #1633    +/-   ##
========================================
  Coverage   99.64%   99.65%            
========================================
  Files        2240     2240            
  Lines      240291   240106   -185     
  Branches     1072     1076     +4     
========================================
- Hits       239432   239271   -161     
+ Misses        838      814    -24     
  Partials       21       21            

Impacted Files	Coverage Δ
src/locales/en/word/adjective.ts	100.00% <ø> (ø)
src/locales/en/word/adverb.ts	100.00% <ø> (ø)
src/locales/en/word/noun.ts	100.00% <ø> (ø)
src/locales/en/word/verb.ts	100.00% <ø> (ø)
src/modules/internet/user-agent.ts	91.08% <0.00%> (+6.48%)	⬆️

[Shinigami92]

Looks like there is a merge conflict with test/__snapshots__/system.spec.ts.snap
Please rebase your PR and solve it

---

I would like to softly "enforce" a required approval from @xDivisionByZerox for this PR

[rcfox]

These merge conflicts are going to keep cropping up as other changes are merged in. I'm going to wait until this ticket is otherwise ready to be merged and handle conflicts then.

[Shinigami92]

Okay, I added some ":thinking:" to the first two files

I think we need to add a sentence / explanation to a file why some words are not allowed

Maybe the contrib guidelines, maybe a comment at the top of the file?

I'm not sure about the colors, we could say: no colors => use colors module for that and I'm fine
I'm not sure about some words like "lame" as yeah they might be like "boring" but I don't think they need to be totally omitted

"obese", "heterosexual", "homosexual" => I think it is more inclusive to have these words in our set as the otherway around

There are some alcoholic words 🤔 maybe we need to transfer these to the requested food module (like colors)

"dwarf" => it is just a fantasy word 🤔

I understand why to remove sexual affected words, but not sure where to draw the line between normal talk and "above-18" words

[ST-DDT]

I think we need to add a sentence / explanation to a file why some words are not allowed

"obese", "heterosexual", "homosexual" => I think it is more inclusive to have these words in our set as the otherway around

I understand why to remove sexual affected words, but not sure where to draw the line between normal talk and "above-18" words

faker/CODE_OF_CONDUCT.md

Line 5 in db6b555

In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.

Since there is no need to include any words regarding

age, body size, disability, ethnicity, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation

we should avoid adding any of them, because we still have plenty of other words.
(Just to prevent accidentally offending someone by generating good ___ or bad ___.)
The list of words is supposed to free of any intent to avoid creating offense by joining valuing words to words with intent.
It is easier to remove words referring to specific persons, ... than removing words that contain value.

Maybe the contrib guidelines

Maybe, I just don't know how to exactly formulate that.

maybe a comment at the top of the file?

This is somewhat special to the word category in general and not a single file.

[terryknowlton]

👍 We appreciate the cleanup.

[Shinigami92]

We also discussed to remove entries from locales where a file contains more then 1k entries (like names or nouns) so files are not getting bigger and bigger
1k entries are more then enough for normal use cases

[xDivisionByZerox]

I'll approve this for two reasons, even tho I'm not happy with some words being removed:

1. It's reasonable to have this in the alpha release, as people are actually interested in this
2. As @ST-DDT said: We have so many words in the en locale, it doesn't matter if we get rid of some