fix(person): Incorrect behavior of name.firstName() function

[matthewmayer]

fix #547 for az,id_ID, lv, ro, ru, sk, uk locales
fix #1553 for de_AT, nl_BE, en_IN, en_AU and el locales

[codecov]

Codecov Report

Merging #1610 (86af798) into next (2d0ca3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff            @@
##             next    #1610    +/-   ##
========================================
  Coverage   99.64%   99.65%            
========================================
  Files        2227     2244    +17     
  Lines      240254   240413   +159     
  Branches     1070     1073     +3     
========================================
+ Hits       239396   239578   +182     
+ Misses        837      814    -23     
  Partials       21       21            

Impacted Files	Coverage Δ
src/locales/az/person/first_name.ts	100.00% <100.00%> (ø)
src/locales/az/person/index.ts	100.00% <100.00%> (ø)
src/locales/de_AT/person/female_first_name.ts	100.00% <100.00%> (ø)
src/locales/de_AT/person/first_name.ts	100.00% <100.00%> (ø)
src/locales/de_AT/person/index.ts	100.00% <100.00%> (ø)
src/locales/de_AT/person/male_first_name.ts	100.00% <100.00%> (ø)
src/locales/el/person/female_first_name.ts	100.00% <100.00%> (ø)
src/locales/el/person/first_name.ts	100.00% <100.00%> (ø)
src/locales/el/person/index.ts	100.00% <100.00%> (ø)
src/locales/el/person/male_first_name.ts	100.00% <100.00%> (ø)
... and 26 more

[ST-DDT]

It doesnt fix the underlying issue, but IMO it fixes the symptoms so it is good enough.

We have to treat the underlying issue later though (in a new issue if we havent one already).

[matthewmayer]

For the four locales de_AT, nl_BE, en_IN and en_AU it was straightforward to split the first_name.ts file into two gendered files. This solves this problem in Faker 7.x:

> faker.setLocale("de_AT")
> faker.name.firstName()
'Leandra' //ok, this is from de_AT
> faker.name.firstName("female")
'Brenda' //wrong, this is from en

[matthewmayer]

For el, all the names in first_name.ts were actually male first names! So I made that male_first_name and added some new female_first_names based on popular first names from statistics.gr

> faker.setLocale("el")
> faker.person.firstName()
'Διονύσιος'
> faker.person.firstName("female")
'Αννα'
> faker.person.firstName("male")
'Παρασκευάς'

[matthewmayer]

For the remaining locales the names are either intermingled or I don't know the languages well enough to tell, so this will have to wait until later refactoring:

de_CH
es_MX
ge
ko
ne
zh_TW

[ST-DDT]

Just to be sure, did you only use the mergeArrays function if the "generic" name was exactly the union of "female" and "male"?

Nevermind. I checked myself. The files were either missing before or are matching the union.