Skip to content

fix(locale): mk (Macedonian) names should use cyrillic а#1557

Merged
Shinigami92 merged 3 commits intofaker-js:nextfrom
matthewmayer:chore/mk-cyrillic
Nov 16, 2022
Merged

fix(locale): mk (Macedonian) names should use cyrillic а#1557
Shinigami92 merged 3 commits intofaker-js:nextfrom
matthewmayer:chore/mk-cyrillic

Conversation

@matthewmayer
Copy link
Copy Markdown
Contributor

fix #1556

@matthewmayer matthewmayer requested a review from a team as a code owner November 13, 2022 16:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 13, 2022

Codecov Report

Merging #1557 (5fc8a18) into next (801e9e0) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1557   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2214     2214           
  Lines      238816   238812    -4     
  Branches     1029     1029           
=======================================
- Hits       237954   237950    -4     
  Misses        841      841           
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/mk/person/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/mk/person/female_last_name.ts 100.00% <100.00%> (ø)
src/locales/mk/person/male_first_name.ts 100.00% <100.00%> (ø)

@ejcheng ejcheng added c: bug Something isn't working c: locale Permutes locale definitions p: 1-normal Nothing urgent m: person Something is referring to the person module labels Nov 13, 2022
@ejcheng ejcheng requested a review from a team November 13, 2022 18:00
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Nov 15, 2022
@ST-DDT ST-DDT requested review from a team November 15, 2022 23:40
@Shinigami92 Shinigami92 changed the title fix(locale): mk (Macedonian) names should use all Cyrillic chars not Latin fix(locale): mk (Macedonian) names should use cyrillic а Nov 16, 2022
@Shinigami92 Shinigami92 merged commit 1796559 into faker-js:next Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Some Macedonian names use latin a instead of Cyrillic а

4 participants