fix(locale): change id_ID name to Indonesian#1401
Merged
Shinigami92 merged 3 commits intofaker-js:mainfrom Sep 29, 2022
fzn0x:patch-4
Merged
fix(locale): change id_ID name to Indonesian#1401Shinigami92 merged 3 commits intofaker-js:mainfrom fzn0x:patch-4
Indonesian#1401Shinigami92 merged 3 commits intofaker-js:mainfrom
fzn0x:patch-4
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1401 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2163 2163
Lines 241303 241303
Branches 1017 1017
=======================================
Hits 240396 240396
Misses 886 886
Partials 21 21
|
fzn0x
changed the title
IndonesianIndonesian
ejcheng
approved these changes
Sep 27, 2022
ST-DDT
approved these changes
Sep 27, 2022
Member
|
Change seems to be correct, but worth to notice, that this is not about citizens of Indonesia, but about locale name. I will update the PR title. |
pkuczynski
changed the title
IndonesianIndonesian
pkuczynski
changed the title
Indonesianid_ID locale to Indonesian
pkuczynski
approved these changes
Sep 27, 2022
pkuczynski
changed the title
id_ID locale to IndonesianIndonesian
xDivisionByZerox
approved these changes
Sep 27, 2022
Contributor
Author
|
Thanks @pkuczynski ! |
Shinigami92
changed the title
IndonesianIndonesian
wael-fadlallah
pushed a commit
to wael-fadlallah/faker
that referenced
this pull request
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The citizens of Indonesia should be called
IndonesianI notice that only Indonesian whos using their country name for calling the citizen that originally from Indonesia, it's should be
Indonesian