feat(dev): add male_first_name,female_first_name, jp locale#1217
Merged
ST-DDT merged 4 commits intofaker-js:mainfrom Aug 2, 2022
satoc0629:feat/add_jp_male_and_female_first_name
Merged
feat(dev): add male_first_name,female_first_name, jp locale#1217ST-DDT merged 4 commits intofaker-js:mainfrom satoc0629:feat/add_jp_male_and_female_first_name
ST-DDT merged 4 commits intofaker-js:mainfrom
satoc0629:feat/add_jp_male_and_female_first_name
Conversation
xDivisionByZerox
added
p: 1-normal
Codecov Report
@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
+ Coverage 99.62% 99.63% +0.01%
==========================================
Files 2153 2155 +2
Lines 236543 236831 +288
Branches 980 984 +4
==========================================
+ Hits 235655 235967 +312
+ Misses 867 843 -24
Partials 21 21
|
ST-DDT
approved these changes
Aug 1, 2022
Member
ST-DDT
left a comment
ST-DDT
left a comment
There was a problem hiding this comment.
Reviewed using google translate. Looks good to me.
ejcheng
approved these changes
Aug 1, 2022
Member
ejcheng
left a comment
ejcheng
left a comment
There was a problem hiding this comment.
Also reviewed using Google Translate, lgtm
Shinigami92
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.