feat(image): add image via.placeholder provider#1186
feat(image): add image via.placeholder provider#1186Shinigami92 merged 22 commits intofaker-js:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1186 +/- ##
========================================
Coverage 99.63% 99.63%
========================================
Files 2155 2156 +1
Lines 236884 236988 +104
Branches 994 1007 +13
========================================
+ Hits 236020 236124 +104
Misses 843 843
Partials 21 21
|
ejcheng
left a comment
There was a problem hiding this comment.
We should specify that width and height are in pixels.
- include . after jsdoc comments - specifiy that width and height is in pixels
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
…into feat/image-placeholder
|
Please update the tests so the dont fail anymore. |
…into feat/image-placeholder
|
@Devdre1909 May I go ahead and fix these things to get this merged or do you wish to do this yourselves? |
I will. |
Hi @Devdre1909 , it seems to me that site does not exist anymore |
|
See #2477 While the homepage of the site now promotes am unrelated business the images appear to continue to work for now. |
|
It seems that the via.placeholder.com images API is not longer active. placeholder.com is still alive; however, via.placeholder.com does not resolve. Image URL within the test JSON are no longer valid. |
|
Thanks for the report. We have deprecated it: The deprecation will be released in a few days. As a workaround, you can use: faker/src/modules/image/index.ts Line 307 in bddce72 |
Issue #1111
Add support for https://placeholder.com/
width, height, text, format, background color, and text color supported