You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Considering the other PR, we should consider whether we want to introduce a format parameter instead.
I really dislike the idea. For me, it doesn't make sense that coordinates would be strings. But we (as a library) should allow stringified strings as input parameters due to the nature of JS and enhancing the dx when using Faker.
I really dislike the idea. For me, it doesn't make sense that coordinates would be strings. But we (as a library) should allow stringified strings as input parameters due to the nature of JS and enhancing the dx when using Faker.
Further discussion regarding that topic please in #1066 or a separate issue/discussion.
Shinigami92
changed the title
refactor(address)!: latitude/longitude return type
refactor(location)!: change latitude/longitude to return number
Oct 13, 2022
Shinigami92
changed the title
refactor(location)!: change latitude/longitude to return number
feat(location)!: latitude/longitude returns number
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breaking changeCannot be merged when next version is not a major releasec: refactorPR that affects the runtime behavior, but doesn't add new features or fixes bugsm: locationSomething is referring to the location modulep: 1-normalNothing urgent
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes to return type of
address.latitude()andaddress.longitude()fromstringtonumber.Related to #1058.
This is a breaking change! Do not merge until the next major release.