fix(typescript): support module Node16/NodeNext#1005
Merged
Shinigami92 merged 1 commit intofaker-js:mainfrom May 25, 2022
julienfouilhe:nodenext
Merged
fix(typescript): support module Node16/NodeNext#1005Shinigami92 merged 1 commit intofaker-js:mainfrom julienfouilhe:nodenext
Shinigami92 merged 1 commit intofaker-js:mainfrom
julienfouilhe:nodenext
Conversation
Shinigami92
added
c: bug
Shinigami92
approved these changes
May 25, 2022
Member
|
After this is merged I would like to release the next version of faker |
Shinigami92
changed the title
"module": "node16" with node and ESM
Codecov Report
@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 2113 2113
Lines 227001 227001
Branches 983 982 -1
==========================================
- Hits 226256 226253 -3
- Misses 725 728 +3
Partials 20 20
|
prisis
approved these changes
May 25, 2022
Merged
Minozzzi
pushed a commit
to Minozzzi/faker
that referenced
this pull request
Jul 19, 2022
Co-authored-by: Andrew Ross <rossirsa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1004
Recreating #979 (without changing the base
"types"field)