Skip to content

Commit 5eb386f

Browse files
committed
fix(person): Incorrect behavior of name.firstName() function - remove duplicates
1 parent e1b78a1 commit 5eb386f

7 files changed

Lines changed: 21 additions & 14 deletions

File tree

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// We don't have a generic first name list for this locale
2-
// So simply concatenate male and female lists to avoid falling back to fallback locale
2+
// So simply concatenate male and female lists and remove any duplicates
3+
// This avoids falling back to fallback locale
34
import female_first_name from './female_first_name';
45
import male_first_name from './male_first_name';
56

6-
export default [...female_first_name, ...male_first_name];
7+
export default [...new Set([...female_first_name, ...male_first_name])];
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// We don't have a generic first name list for this locale
2-
// So simply concatenate male and female lists to avoid falling back to fallback locale
2+
// So simply concatenate male and female lists and remove any duplicates
3+
// This avoids falling back to fallback locale
34
import female_first_name from './female_first_name';
45
import male_first_name from './male_first_name';
56

6-
export default [...female_first_name, ...male_first_name];
7+
export default [...new Set([...female_first_name, ...male_first_name])];
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// We don't have a generic first name list for this locale
2-
// So simply concatenate male and female lists to avoid falling back to fallback locale
2+
// So simply concatenate male and female lists and remove any duplicates
3+
// This avoids falling back to fallback locale
34
import female_first_name from './female_first_name';
45
import male_first_name from './male_first_name';
56

6-
export default [...female_first_name, ...male_first_name];
7+
export default [...new Set([...female_first_name, ...male_first_name])];
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// We don't have a generic first name list for this locale
2-
// So simply concatenate male and female lists to avoid falling back to fallback locale
2+
// So simply concatenate male and female lists and remove any duplicates
3+
// This avoids falling back to fallback locale
34
import female_first_name from './female_first_name';
45
import male_first_name from './male_first_name';
56

6-
export default [...female_first_name, ...male_first_name];
7+
export default [...new Set([...female_first_name, ...male_first_name])];
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// We don't have a generic first name list for this locale
2-
// So simply concatenate male and female lists to avoid falling back to fallback locale
2+
// So simply concatenate male and female lists and remove any duplicates
3+
// This avoids falling back to fallback locale
34
import female_first_name from './female_first_name';
45
import male_first_name from './male_first_name';
56

6-
export default [...female_first_name, ...male_first_name];
7+
export default [...new Set([...female_first_name, ...male_first_name])];
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// We don't have a generic first name list for this locale
2-
// So simply concatenate male and female lists to avoid falling back to fallback locale
2+
// So simply concatenate male and female lists and remove any duplicates
3+
// This avoids falling back to fallback locale
34
import female_first_name from './female_first_name';
45
import male_first_name from './male_first_name';
56

6-
export default [...female_first_name, ...male_first_name];
7+
export default [...new Set([...female_first_name, ...male_first_name])];
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// We don't have a generic first name list for this locale
2-
// So simply concatenate male and female lists to avoid falling back to fallback locale
2+
// So simply concatenate male and female lists and remove any duplicates
3+
// This avoids falling back to fallback locale
34
import female_first_name from './female_first_name';
45
import male_first_name from './male_first_name';
56

6-
export default [...female_first_name, ...male_first_name];
7+
export default [...new Set([...female_first_name, ...male_first_name])];

0 commit comments

Comments
 (0)