Skip to content

Add component stack to invariant #11652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ethan-Arrowood wants to merge 12 commits into from
Closed

Add component stack to invariant #11652

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9813b63
Attempt add getCurrentFiberStackAddendum
Ethan-Arrowood Jan 6, 2018
8825ba2
add toErrorWithStack
Ethan-Arrowood Jan 6, 2018
c4b1655
Fixed custom matcher
Ethan-Arrowood Jan 6, 2018
3911764
change toContent
Ethan-Arrowood Jan 8, 2018
d117d9c
prettify and lint
Ethan-Arrowood Jan 8, 2018
ffbae2f
add stripStackTrace
Ethan-Arrowood Jan 9, 2018
257ef7e
remove toContent. add childFiber
Ethan-Arrowood Jan 9, 2018
f87e8c9
Add stack to child, input, textarea
Ethan-Arrowood Jan 9, 2018
8ae3596
remove mutation
Ethan-Arrowood Jan 10, 2018
b325320
actually remove mutation maybe
Ethan-Arrowood Jan 11, 2018
204d97c
Fix test-prod issues
Ethan-Arrowood Jan 11, 2018
26e9a9e
keep noop children
Ethan-Arrowood Jan 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,11 @@ describe('ReactIncrementalErrorHandling', () => {
return str && str.replace(/in .+? \(at .+?:\d+\)/g, '').trim();
}

function stripStackTrace(obj) {
let stripped = [...obj];
stripped[0].prop = removeStack(stripped[0].prop);
return stripped;
function stripStackTrace(compSpan) {
return [{
...compSpan[0],
prop: removeStack(compSpan[0].prop),
}];

@gaearon gaearon Jan 11, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is (incorrectly) more than one child, this will ignore it. Let's make sure we don't "lose" any input children?

@Ethan-Arrowood Ethan-Arrowood Jan 11, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Let me see what I can come up with.

}

it('catches render error in a boundary during full deferred mounting', () => {
Expand Down