Fix false positive SVG hydration warning for mixed case tags#11174
Merged
Conversation
It causes a false positive warning on hydration.
Collaborator
Author
sebmarkbage
approved these changes
Oct 10, 2017
sebmarkbage
left a comment
sebmarkbage
left a comment
Contributor
There was a problem hiding this comment.
I think this makes sense. We are assuming that any other incorrect casing would not work as expected and therefore would get fixed.
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
This was referenced Feb 2, 2018
This was referenced Mar 1, 2018
This was referenced Mar 21, 2018
This was referenced Aug 7, 2020
This was referenced Sep 27, 2021
mrizwanashiq
pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
…1174) * Add a failing test for <feMorphology> SSR It causes a false positive warning on hydration. * Make hydration tag comparison case insensitive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10772.
I opted for the fix suggested by @webcarrot in #10772 (comment).
It seems like the easiest and I don’t see a realistic situation in which it wouldn’t work. I guess it could break if you rendered
<femorphology>on the server but<feMorphology>on the client, but who would possibly do that?