Skip to content

Suggest reactstrap instead of react-bootstrap - #4703

Merged
Timer merged 2 commits into
react:nextfrom
Brew-Brew:mynext
Jun 30, 2018
Merged

Suggest reactstrap instead of react-bootstrap#4703
Timer merged 2 commits into
react:nextfrom
Brew-Brew:mynext

Conversation

@Brew-Brew

@Brew-Brew Brew-Brew commented Jun 29, 2018

Copy link
Copy Markdown
Contributor

I thought it would be great to recommend reactstrap for now, instead of react-bootstrap. :)

@bugzpodder

Copy link
Copy Markdown

you don't have to create new PRs when revising. you can just push a commit to your branch, and it should automatically reflect here.

@Brew-Brew

Brew-Brew commented Jun 29, 2018

Copy link
Copy Markdown
Contributor Author

@bugzpodder But i had to change pr branch from master to next ..
#4700

@Timer

Timer commented Jun 30, 2018

Copy link
Copy Markdown
Contributor

💯

@guledali

Copy link
Copy Markdown

This PR needs a little clean up consider to follow this https://github.com/facebook/create-react-app/pull/4314/files

This is by the creators of Reactstrap

@bugzpodder

Copy link
Copy Markdown

What's the difference aside from gist's contents?

@guledali

Copy link
Copy Markdown

@bugzpodder You don't need to specify the version 4 like bootstrap@4 . Bootstrap is currently on 4.1 soon 4.2 even reactstrap https://reactstrap.github.io/ site recommend just installing bootstrap without specify version number. The problem is that will always fallback on bootstrap@4 similar to previous one bootstrap@3.

I think reason the 4 is there bootstrap@4 the person copied the existing and just swapped out bootstrap keyword to reactstrap.

Go ahead and copy that PR it should take care of all issues

@Timer

Timer commented Jun 30, 2018

Copy link
Copy Markdown
Contributor

We want to be intentional about the version. The @4 will stay; people still actively use 3 so being explicit never hurts for clarity.

@guledali

guledali commented Jul 1, 2018

Copy link
Copy Markdown

@Timer Sure, you're the boss here, I still think you shouldn't have to specify a version number.

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
* Suggest `reactstrap` instead of `react-bootstrap`

* Update README.md
@lock lock Bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants