Skip to content

Add svg rendering for error example - #3825

Merged
gaearon merged 2 commits into
react:nextfrom
marionebl:docs-svg-error-example
Jan 17, 2018
Merged

Add svg rendering for error example#3825
gaearon merged 2 commits into
react:nextfrom
marionebl:docs-svg-error-example

Conversation

@marionebl

@marionebl marionebl commented Jan 17, 2018

Copy link
Copy Markdown
Contributor
  • Add screencast:error run-script
  • Replace png error example with static SVG rendering
  • Match style of Getting started screencast

@gaearon gaearon added this to the 2.0.0 milestone Jan 17, 2018
@gaearon
gaearon merged commit a3d002e into react:next Jan 17, 2018
@gaearon

gaearon commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

Thanks! How hard would it be to do the test runner with a filtering example?

@marionebl

Copy link
Copy Markdown
Contributor Author

Should be doable, what pattern do you have in mind?

@gaearon

gaearon commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

Just "app" maybe

@marionebl

Copy link
Copy Markdown
Contributor Author

@gaearon

gaearon commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

I think it would look more impressive if there were more tests 😄 Can we use some open source project? e.g. Redux examples use CRA scripts.

Another minor thing is that Jest removed autocomplete in 22 because of some issues. So let's wait until we release 2.x alpha and then we can record the more recent behavior.

akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
* Add svg rendering for error example

* Use static svg error example
@lock lock Bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants