Skip to content

Commit 3826e88

Browse files
ndmitchellmeta-codesync[bot]
authored andcommitted
Include Kotlin runtime in Java test runner archive
Summary: `BasePerTestCoverageRunListener` is implemented in Kotlin, but `testrunner-bin-fixed` filtered `kotlin/` classes out of the vanilla Java test runner archive. Selective Java coverage therefore failed during listener initialization with `NoClassDefFoundError: kotlin/text/Regex` before producing coverage data. Preserve the Kotlin runtime in the vanilla archive, matching the existing Android runner behavior, and teach the archive guard to allow that namespace while continuing to exactly allowlist other entries. Reviewed By: NavidQar Differential Revision: D112132628 fbshipit-source-id: c239edd1a5b67a5b979b96cb16e0e13c017503db
1 parent 4c34baf commit 3826e88

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • prelude/toolchains/android/src/com/facebook/buck/testrunner

prelude/toolchains/android/src/com/facebook/buck/testrunner/BUCK

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ fb_native.zip_file(
263263
name = "testrunner-bin-fixed",
264264
out = "testrunner-bin-fixed.jar",
265265
entries_to_exclude = [
266-
"^(?!com/facebook/buck/|META-INF/services/org.junit.jupiter|com/fasterxml/jackson/core).*",
266+
"^(?!com/facebook/buck/|META-INF/services/org.junit.jupiter|com/fasterxml/jackson/core|kotlin/).*",
267267
],
268268
visibility = [
269269
"PUBLIC",

0 commit comments

Comments
 (0)