adress Andrey's comments

Author: Dimitry Kh

CHANGELOG.md

@@ -4,7 +4,8 @@
 
 - Added: [#5699](https://github.com/ethereum/aleth/pull/5699) EIP 2046: Reduced gas cost for static calls made to precompiles.
 - Added: [#5752](https://github.com/ethereum/aleth/pull/5752) [#5753](https://github.com/ethereum/aleth/pull/5753) Implement EIP1380 (reduced gas costs for call-to-self).
-- Removed: [#5760](https://github.com/ethereum/aleth/pull/5760) Official support for Visual Studio 2015 has been dropped. Compilation with this compiler is expected to stop working after migration to C++14.
+- Changed: [#5801](https://github.com/ethereum/aleth/pull/5801) `testeth -t BlockchainTests` command now doesn't run the tests for the forks before Istanbul. To run those tests use a separate LegacyTests suite with command `testeth -t LegacyTests/Constantinople/BlockchainTests`.
+- Removed: [#5760](https://github.com/ethereum/aleth/pull/5760) Official support for Visual Studio 2015 has been dropped. Compilation with this compiler is expected to stop working after migration to C++14. 
 - Fixed: [#5792](https://github.com/ethereum/aleth/pull/5792) Faster and cheaper execution of RPC functions which query blockchain state (e.g. getBalance).
 
 ## [1.7.0] - Unreleased

test/tools/jsontests/BlockChainTests.cpp

@@ -1062,7 +1062,7 @@ class bcTransitionFixture {
 BOOST_AUTO_TEST_SUITE(BlockchainTests)
 
 // Tests that contain only valid blocks and check that import is correct
-BOOST_FIXTURE_TEST_SUITE(ValidBlocks, bcValidTestFixture<test::BlockchainValidTestSuite>)
+BOOST_FIXTURE_TEST_SUITE(ValidBlocks, bcTestFixture<test::BlockchainValidTestSuite>)
 BOOST_AUTO_TEST_CASE(bcBlockGasLimitTest) {}
 BOOST_AUTO_TEST_CASE(bcExploitTest) {}
 BOOST_AUTO_TEST_CASE(bcForkStressTest) {}
@@ -1078,7 +1078,7 @@ BOOST_AUTO_TEST_CASE(bcWalletTest) {}
 BOOST_AUTO_TEST_SUITE_END()
 
 // Tests that might have invalid blocks and check that those are rejected
-BOOST_FIXTURE_TEST_SUITE(InvalidBlocks, bcInvalidTestFixture<test::BlockchainInvalidTestSuite>)
+BOOST_FIXTURE_TEST_SUITE(InvalidBlocks, bcTestFixture<test::BlockchainInvalidTestSuite>)
 BOOST_AUTO_TEST_CASE(bcBlockGasLimitTest) {}
 BOOST_AUTO_TEST_CASE(bcForgedTest) {}
 BOOST_AUTO_TEST_CASE(bcInvalidHeaderTest) {}

test/tools/jsontests/BlockChainTests.h

@@ -45,18 +45,18 @@ class bcGeneralTestsFixture : public StateTestFixtureBase<BCGeneralStateTestsSui
 };
 
 template <class T>
-class bcValidTestFixture
+class bcTestFixture
 {
 public:
-    bcValidTestFixture(std::set<TestExecution> const& _execFlags = {})
+    bcTestFixture(std::set<TestExecution> const& _execFlags = {})
     {
         T suite;
         if (_execFlags.count(TestExecution::NotRefillable) &&
             (Options::get().fillchain || Options::get().filltests))
             BOOST_FAIL("Tests are sealed and not refillable!");
 
         string const casename = boost::unit_test::framework::current_test_case().p_name;
-        boost::filesystem::path suiteFillerPath = suite.getFullPathFiller(casename).parent_path();
+        boost::filesystem::path const suiteFillerPath = suite.getFullPathFiller(casename).parent_path();
 
         // skip wallet test as it takes too much time (250 blocks) run it with --all flag
         if (casename == "bcWalletTest" && !test::Options::get().all)
@@ -71,25 +71,6 @@ class bcValidTestFixture
     }
 };
 
-template <class T>
-class bcInvalidTestFixture
-{
-public:
-    bcInvalidTestFixture(std::set<TestExecution> const& _execFlags = {})
-    {
-        T suite;
-        if (_execFlags.count(TestExecution::NotRefillable) &&
-            (Options::get().fillchain || Options::get().filltests))
-            BOOST_FAIL("Tests are sealed and not refillable!");
-
-        string const casename = boost::unit_test::framework::current_test_case().p_name;
-        boost::filesystem::path suiteFillerPath = suite.getFullPathFiller(casename).parent_path();
-
-        suite.runAllTestsInFolder(casename);
-        test::TestOutputHelper::get().markTestFolderAsFinished(suiteFillerPath, casename);
-    }
-};
-
 class TransitionTestsSuite: public TestSuite
 {
     json_spirit::mValue doTests(json_spirit::mValue const& _input, bool _fillin) const override;

test/tools/jsontests/LegacyTests.h

@@ -37,7 +37,7 @@ class BCGeneralStateTestsSuiteLegacyConstantinople : public BCGeneralStateTestsS
     }
 };
 
-class BlockchainInvalidTestSuiteLegacyConstantinople : public BlockchainInvalidTestSuite
+class LegacyConstantinopleBlockchainInvalidTestSuite : public BlockchainInvalidTestSuite
 {
     boost::filesystem::path suiteFolder() const override
     {
@@ -49,7 +49,7 @@ class BlockchainInvalidTestSuiteLegacyConstantinople : public BlockchainInvalidT
     }
 };
 
-class BlockchainValidTestSuiteLegacyConstantinople : public BlockchainValidTestSuite
+class LegacyConstantinopleBlockchainValidTestSuite : public BlockchainValidTestSuite
 {
     boost::filesystem::path suiteFolder() const override
     {
@@ -81,19 +81,19 @@ class LegacyConstantinopleBCGeneralStateTestFixture
 };
 
 class LegacyConstantinoplebcInvalidTestFixture
-  : public bcInvalidTestFixture<BlockchainInvalidTestSuiteLegacyConstantinople>
+  : public bcTestFixture<LegacyConstantinopleBlockchainInvalidTestSuite>
 {
 public:
     LegacyConstantinoplebcInvalidTestFixture()
-      : bcInvalidTestFixture({TestExecution::NotRefillable})
+      : bcTestFixture({TestExecution::NotRefillable})
     {}
 };
 
 class LegacyConstantinoplebcValidTestFixture
-  : public bcValidTestFixture<BlockchainValidTestSuiteLegacyConstantinople>
+  : public bcTestFixture<LegacyConstantinopleBlockchainValidTestSuite>
 {
 public:
-    LegacyConstantinoplebcValidTestFixture() : bcValidTestFixture({TestExecution::NotRefillable}) {}
+    LegacyConstantinoplebcValidTestFixture() : bcTestFixture({TestExecution::NotRefillable}) {}
 };