Conversation
nzakas
marked this pull request as ready for review
February 19, 2025 18:19
fasttime
reviewed
Feb 20, 2025
Member
|
I'll leave this open until today's release in case someone else would like to review. |
fasttime
requested changes
Feb 21, 2025
fasttime
left a comment
fasttime
left a comment
Member
There was a problem hiding this comment.
Oh, actually the path of the .d.ts file in package.json is wrong. I was wondering why VSCode wasn't finding the new types locally.
Co-authored-by: Francesco Trotta <github@fasttime.org>
Member
Author
|
Good catch! |
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #178 to include types in the package:
@types/eslint__eslintrc)This eliminates the need for
@types/eslint__eslintrc.