feat: report max-depth violations on keywords (#20943)

Author: Pixel998

lib/rules/max-depth.js

@@ -54,6 +54,8 @@ module.exports = {
 	},
 
 	create(context) {
+		const sourceCode = context.sourceCode;
+
 		//--------------------------------------------------------------------------
 		// Helpers
 		//--------------------------------------------------------------------------
@@ -102,6 +104,7 @@ module.exports = {
 			if (len > maxDepth) {
 				context.report({
 					node,
+					loc: sourceCode.getFirstToken(node).loc,
 					messageId: "tooDeeply",
 					data: { depth: len, maxDepth },
 				});

tests/lib/rules/max-depth.js

@@ -80,6 +80,10 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 3, maxDepth: 2 },
+					line: 1,
+					column: 43,
+					endLine: 1,
+					endColumn: 45,
 				},
 			],
 		},
@@ -91,6 +95,10 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 3, maxDepth: 2 },
+					line: 1,
+					column: 44,
+					endLine: 1,
+					endColumn: 46,
 				},
 			],
 		},
@@ -101,6 +109,10 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 2, maxDepth: 1 },
+					line: 1,
+					column: 38,
+					endLine: 1,
+					endColumn: 41,
 				},
 			],
 		},
@@ -111,6 +123,10 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 2, maxDepth: 1 },
+					line: 1,
+					column: 52,
+					endLine: 1,
+					endColumn: 54,
 				},
 			],
 		},
@@ -121,6 +137,10 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 2, maxDepth: 1 },
+					line: 1,
+					column: 8,
+					endLine: 1,
+					endColumn: 10,
 				},
 			],
 		},
@@ -131,6 +151,24 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 2, maxDepth: 1 },
+					line: 1,
+					column: 33,
+					endLine: 1,
+					endColumn: 35,
+				},
+			],
+		},
+		{
+			code: "function foo() { if (a) { switch (b) { case 1: foo(); } } }",
+			options: [1],
+			errors: [
+				{
+					messageId: "tooDeeply",
+					data: { depth: 2, maxDepth: 1 },
+					line: 1,
+					column: 27,
+					endLine: 1,
+					endColumn: 33,
 				},
 			],
 		},
@@ -142,6 +180,10 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 2, maxDepth: 1 },
+					line: 1,
+					column: 39,
+					endLine: 1,
+					endColumn: 41,
 				},
 			],
 		},
@@ -152,10 +194,18 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 2, maxDepth: 1 },
+					line: 1,
+					column: 33,
+					endLine: 1,
+					endColumn: 35,
 				},
 				{
 					messageId: "tooDeeply",
 					data: { depth: 3, maxDepth: 1 },
+					line: 1,
+					column: 45,
+					endLine: 1,
+					endColumn: 47,
 				},
 			],
 		},
@@ -165,6 +215,10 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 5, maxDepth: 4 },
+					line: 1,
+					column: 68,
+					endLine: 1,
+					endColumn: 70,
 				},
 			],
 		},
@@ -177,6 +231,10 @@ ruleTester.run("max-depth", rule, {
 				{
 					messageId: "tooDeeply",
 					data: { depth: 3, maxDepth: 2 },
+					line: 1,
+					column: 43,
+					endLine: 1,
+					endColumn: 45,
 				},
 			],
 		},
@@ -185,14 +243,28 @@ ruleTester.run("max-depth", rule, {
 			code: "function foo() { if (a) { if (b) { if (c) { if (d) { if (e) {} } } } } }",
 			options: [{}],
 			errors: [
-				{ messageId: "tooDeeply", data: { depth: 5, maxDepth: 4 } },
+				{
+					messageId: "tooDeeply",
+					data: { depth: 5, maxDepth: 4 },
+					line: 1,
+					column: 54,
+					endLine: 1,
+					endColumn: 56,
+				},
 			],
 		},
 		{
 			code: "function foo() { if (true) {} }",
 			options: [{ max: 0 }],
 			errors: [
-				{ messageId: "tooDeeply", data: { depth: 1, maxDepth: 0 } },
+				{
+					messageId: "tooDeeply",
+					data: { depth: 1, maxDepth: 0 },
+					line: 1,
+					column: 18,
+					endLine: 1,
+					endColumn: 20,
+				},
 			],
 		},
 
@@ -206,6 +278,8 @@ ruleTester.run("max-depth", rule, {
 					data: { depth: 3, maxDepth: 2 },
 					line: 1,
 					column: 38,
+					endLine: 1,
+					endColumn: 40,
 				},
 			],
 		},
@@ -219,6 +293,8 @@ ruleTester.run("max-depth", rule, {
 					data: { depth: 3, maxDepth: 2 },
 					line: 1,
 					column: 47,
+					endLine: 1,
+					endColumn: 49,
 				},
 			],
 		},
@@ -232,6 +308,8 @@ ruleTester.run("max-depth", rule, {
 					data: { depth: 3, maxDepth: 2 },
 					line: 1,
 					column: 64,
+					endLine: 1,
+					endColumn: 66,
 				},
 			],
 		},
@@ -245,6 +323,8 @@ ruleTester.run("max-depth", rule, {
 					data: { depth: 3, maxDepth: 2 },
 					line: 1,
 					column: 80,
+					endLine: 1,
+					endColumn: 82,
 				},
 			],
 		},