Skip to content

Commit 2ac9cc1

Browse files
jdmunroericlewis
authored andcommitted
Remove SnapshotViewIOS from public interface (react#23497)
Summary: Part of Lean Core react#23313 Removes `SnapshotViewIOS` from the public RN interface. I think there's a wider discussion to be had here about whether `RCTTest` should be part of the public distribution or at least whether this should be split into a separate utils package. It's mainly used by the RNTester app. It seems to be little known about but there are [some references to it online](https://blog.callstack.io/testing-your-react-native-apps-abfe41903dfd). [iOS] [Removed] - `SnapshotViewIOS` is no longer publicly exported from RN Pull Request resolved: react#23497 Differential Revision: D14123280 Pulled By: cpojer fbshipit-source-id: badaf6cb5d2195268f0f8b429fc11d6525747708
1 parent d097951 commit 2ac9cc1

4 files changed

Lines changed: 1 addition & 4 deletions

File tree

Libraries/react-native/react-native-implementation.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,6 @@ module.exports = {
124124
);
125125
return require('Slider');
126126
},
127-
get SnapshotViewIOS() {
128-
return require('SnapshotViewIOS');
129-
},
130127
get Switch() {
131128
return require('Switch');
132129
},

RNTester/js/RNTesterApp.ios.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ const RNTesterExampleContainer = require('./RNTesterExampleContainer');
2121
const RNTesterExampleList = require('./RNTesterExampleList');
2222
const RNTesterList = require('./RNTesterList.ios');
2323
const RNTesterNavigationReducer = require('./RNTesterNavigationReducer');
24+
const SnapshotViewIOS = require('./SnapshotViewIOS.ios');
2425
const URIActionMap = require('./URIActionMap');
2526

2627
const {
2728
Button,
2829
AppRegistry,
29-
SnapshotViewIOS,
3030
StyleSheet,
3131
Text,
3232
View,
File renamed without changes.

0 commit comments

Comments
 (0)