Upgrade to ember-cli-qunit 4.0 and replace ember-dev with ember-qunit… - #5371
Merged
Conversation
rwjblue
reviewed
Mar 6, 2018
rwjblue
left a comment
rwjblue
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, I did comment on one oddity inline though...
| assert.throws(() => { | ||
| run(() => env.store.createRecord('user', { post: {}})); | ||
| }, /No model was found for 'post'/); | ||
| run(() => { |
Contributor
There was a problem hiding this comment.
This change seems somewhat odd
Contributor
Author
There was a problem hiding this comment.
Indeed, not sure what was going on there. I just moved the runloop back inside the expectAssertion and everything passes so I'm going to commit that change.
Contributor
|
@bmac - looks like I created a merge conflict in yarn.lock, sorry 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-assert-helpers