Ensure ember-data/-private module is emitted properly for ember-cli… - #5031
Merged
Conversation
rwjblue
approved these changes
Jun 22, 2017
| let bowerDeps = this.project.bowerDependencies(); | ||
| this.debugTree = BroccoliDebug.buildDebugCallback('ember-data'); | ||
|
|
||
| var bowerDeps = this.project.bowerDependencies(); |
stefanpenner
force-pushed
the
forward-port
branch
2 times, most recently
from
June 22, 2017 22:08
736f7cc to
d7a8215
Compare
Contributor
|
🎉 |
… < 2.12. ember-cli@2.12 and higher have the addon itself responsible for transpiling modules so that the output of the `treeForAddon` hook is expected to be AMD. Prior versions of ember-cli (i.e. < 2.12) do second pass (that is not possible to disable) to transpile the output of `treeForAddon` **again** (to transpile modules). This commit changes things around leveraging ember-cli-babel@6's built in ability to detect the various ember-cli version scenarios and either transpile `ember-data/-private` down to AMD or not correctly.
stefanpenner
force-pushed
the
forward-port
branch
from
June 22, 2017 23:04
d7a8215 to
8ad6b6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… < 2.12.
ember-cli@2.12 and higher have the addon itself responsible for transpiling
modules so that the output of the
treeForAddonhook is expected to beAMD.
Prior versions of ember-cli (i.e. < 2.12) do second pass (that is not possible
to disable) to transpile the output of
treeForAddonagain (to transpilemodules).
This commit changes things around leveraging ember-cli-babel@6's built in
ability to detect the various ember-cli version scenarios and either
transpile
ember-data/-privatedown to AMD or not correctly.