Conversation
stefanpenner
force-pushed
the
fix-stuff
branch
3 times, most recently
from
February 21, 2017 22:49
7d16d53 to
943b33e
Compare
rwjblue
approved these changes
Feb 21, 2017
chadhietala
reviewed
Feb 21, 2017
|
|
||
| factory.modelName = factory.modelName || modelName; | ||
| // TODO: deprecate this | ||
| klass.modelName = klass.modelName || modelName; |
Contributor
There was a problem hiding this comment.
Can you do Ember.deprecate instead of the TODO?
Contributor
Author
There was a problem hiding this comment.
We don't currently have a path forward yet. I would prefer to deprecate once this is the case.
Contributor
Author
There was a problem hiding this comment.
But will find a path forward for this soon!
Contributor
Author
There was a problem hiding this comment.
@chadhietala I'm doing a follow up PR (right now) that reduces ember-datas dependence on modelName. That will be a pre-cursor to deprecating it.
Contributor
Author
There was a problem hiding this comment.
i've removed many more internal usages of modelName, there are some more low hanging fruit but addressing it fully will be some effort (although I hope we can do asap).
Some notes: #4814
runspired
approved these changes
Feb 21, 2017
*note: this combined with embers factoryFor makes `MODEL_FACTORY_INJECTIONS` irrelevant.*
stefanpenner
force-pushed
the
fix-stuff
branch
from
February 22, 2017 16:53
943b33e to
314ae0b
Compare
This was referenced Feb 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: this combined with embers factoryFor makes
MODEL_FACTORY_INJECTIONSirrelevant.Fixes #4807