Simplify Backburner Usage - #4723
Merged
Merged
Conversation
locks
approved these changes
Jan 9, 2017
Contributor
Author
|
cc @bmac for final review / merging |
bmac
approved these changes
Jan 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR spin up less, schedule less, batch more things, cleaner profiles :)
In a query returning 238 records 34 of which are primary records, this resulted in:
Right now this fails on the tests around support for preloading relationships when doing findRecord, digging in on that.Also includes some additional instrumentation stuff that's part of a different PR + some additions to that instrumentation I'll need to back out.I appear to have pushed this far enough we get failing tests around pushing hasMany's with invalid values. I think something likely just ended up dropping out of the same run loop, investigating.There's still a little bit of low hanging fruit on this.