Skip to content

converts Snapshot to an es6 class instead of using prototype assign - #4715

Merged
bmac merged 1 commit into
warp-drive-data:masterfrom
runspired:feat/es6-snapshot
Jan 13, 2017
Merged

converts Snapshot to an es6 class instead of using prototype assign#4715
bmac merged 1 commit into
warp-drive-data:masterfrom
runspired:feat/es6-snapshot

Conversation

@runspired

Copy link
Copy Markdown
Contributor

Was working on cleaning up some things and just felt this could use a facelift. This isn't for perf, but I'm going to try to isolate it in a profile anyway because I'm personally curious the overall effects of:

  • not setting things on the prototype that we're just going to override in the constructor anyway
  • (obvs babelified) es6 class definitions vs. prototype definition using the Object.assign pattern

@runspired

runspired commented Dec 14, 2016

Copy link
Copy Markdown
Contributor Author

@stefanpenner this is also something that would be a pretty good object to look at the perf of new EmptyObject() vs Object.create(null) on, as it uses it 4x and populates two of them immediately.

@runspired

Copy link
Copy Markdown
Contributor Author

cc @bmac for final review / merging

@locks locks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw

@bmac
bmac merged commit 4932cba into warp-drive-data:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants