[BUGFIX beta] Ember Data should not swallow exceptions from the run loop - #4537
Merged
Conversation
pangratz
approved these changes
Sep 20, 2016
pangratz
reviewed
Sep 20, 2016
pangratz
left a comment
pangratz
left a comment
Contributor
There was a problem hiding this comment.
Is there a way we can test this?
Contributor
Author
|
ping @stefanpenner. @igorT requests your eyes on this pr. |
Contributor
Author
|
I'm going to make this a |
Contributor
|
@bmac was this introduced in the last release cycle? |
Contributor
Author
|
Yes it was introduced by #4489. |
Contributor
|
ah cool, just wanted to verify. happy to merge once we move it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4533