[BUGFIX beta] add assertions for reference methods on DS.Model - #4499
Merged
pangratz merged 1 commit intoAug 30, 2016
Conversation
Assertions are thrown when the specified relationship doesn't exist or the passed type mismatches the one of the actual relationship.
Contributor
|
is there a way to check for existence of a relationship without getting an exception? |
Contributor
Author
|
Yep: let Person = this.store.modelFor("person");
let rels = Ember.get(Person, "relationshipsByName");
let personRel = rels.get("father");
if (personRel) {
let { kind } = personRel;
assert.ok(kind, "belongsTo");
} |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assertions are thrown when the specified relationship doesn't exist or
the passed type mismatches the one of the actual relationship.
This issue has been raised in the slack channel so adding assertions should help preventing this in the future.