Skip to content

[DOC] Document behavior of object level errors with JSON API - #4141

Merged
pangratz merged 1 commit into
warp-drive-data:masterfrom
adam-knights:doc_ds_errors_base
Feb 10, 2016
Merged

[DOC] Document behavior of object level errors with JSON API#4141
pangratz merged 1 commit into
warp-drive-data:masterfrom
adam-knights:doc_ds_errors_base

Conversation

@adam-knights

Copy link
Copy Markdown
Contributor

This documents behavior added in #3909.

Comment thread addon/-private/system/model/errors.js Outdated

The JSON API spec also allows for object level errors to be placed
in an object with pointer `data`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like travis didn't like this pr because of extra trailing whitespace on some of these blank lines. @adam-knights do you mind amending this commit and removing the whitespace?

@pangratz

pangratz commented Feb 9, 2016

Copy link
Copy Markdown
Contributor

Besides my tiny comments this looks good to me. Thank you very much @adam-knights!

@adam-knights

Copy link
Copy Markdown
Contributor Author

np, thanks @pangratz @bmac, those changes are now made.

pangratz added a commit that referenced this pull request Feb 10, 2016
[DOC] Document behavior of object level errors with JSON API
@pangratz
pangratz merged commit be03d51 into warp-drive-data:master Feb 10, 2016
@pangratz

Copy link
Copy Markdown
Contributor

Thanks @adam-knights!

@adam-knights
adam-knights deleted the doc_ds_errors_base branch February 10, 2016 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants