[CLEANUP] use methods from utils module directly - #4030
Merged
Conversation
Since ember-data is a proper addon now, the utility functions in
`ember-data/-private/utils` can now be imported and invoked within the
tests.
`assertPolymorphicType()` is now tested directly instead of relying on
it being used within `Model.get('relationship').add()`.
`modelHasAttributeOrRelationshipNamedType` hasn't been tested since it
couldn't be imported in the tests.
bmac
added a commit
that referenced
this pull request
Dec 28, 2015
[CLEANUP] use methods from utils module directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ember-data is a proper addon now, the utility functions in
ember-data/-private/utilscan now be imported and invoked within thetests.
assertPolymorphicType()is now tested directly instead of relying onit being used within
Model.get('relationship').add().modelHasAttributeOrRelationshipNamedTypehasn't been tested since itcouldn't be imported in the tests.