[BUGFIX beta] Implement public module API. - #3995
Merged
Merged
Conversation
This replaces the public module API from ember-cli-shims.
Contributor
|
LGTM 👍 |
Contributor
Author
|
Updated again, added the following:
In order to keep backwards compat, we must honor the version of ember-data that is present in If |
In order to keep backwards compat, we must honor the version of ember-data that is present in `bower.json` (even though it is not needed). This is due to the fact that many people update the `package.json` and `bower.json` versions of Ember Data completely independently. If `bower.json` includes `ember-data` a warning will be issued, and that version will be used.
`config/environment.js` is used by ember-cli to allow the addon to provide default configuration to the consuming app. In this case, the configuration here is for the addon's internal development so it belongs in `tests/dummy/config/environment.js` instead.
When using ember-cli-shims prior to 0.1.0, the `ember-data` module that we provide in this addon is overridden by the one provided by the shims repo. This warning should help folks understand what to do *before* they notice an issue.
Contributor
Author
|
Added two more changes:
|
bmac
added a commit
that referenced
this pull request
Dec 14, 2015
[BUGFIX beta] Implement public module API.
Contributor
|
Thanks @rwjblue. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
define && define.petal(which is set by loader.js) is present.bower.jsonincludesember-dataa warning will be issued, and thatversion will be used.