Skip to content

[CLEANUP] Remove ember-new-computed dependency - #3420

Merged
wecc merged 1 commit into
warp-drive-data:masterfrom
pangratz:remove_ember-new-computed-dependency
Jun 23, 2015
Merged

[CLEANUP] Remove ember-new-computed dependency#3420
wecc merged 1 commit into
warp-drive-data:masterfrom
pangratz:remove_ember-new-computed-dependency

Conversation

@pangratz

Copy link
Copy Markdown
Contributor

Since v1.13.0 we use Ember.js-v1.13.0, so this addon is no more needed
since the new computed property syntax is supported out of the box with
this Ember.js version.

@wecc

wecc commented Jun 22, 2015

Copy link
Copy Markdown
Contributor

I find it weird that this pass :) There's a reference to ember-new-computed in Brocfile.js and computedPolyfill is used in:

  • packages/ember-data/lib/system/model/attributes.js
  • packages/ember-data/lib/system/relationships/belongs-to.js
  • packages/ember-data/lib/system/relationships/has-many.js

@pangratz

Copy link
Copy Markdown
Contributor Author

Hmm, good catch. Crazy. Good thing AppVeyor was failing (for a change 😉 ) Haven't seen those. I will clean the references and update the PR...

Since v1.13.0 we use Ember.js-v1.13.0, so this addon is no more needed
since the new computed property syntax is supported out of the box with
this Ember.js version.
wecc added a commit that referenced this pull request Jun 23, 2015
…ndency

[CLEANUP] Remove ember-new-computed dependency
@wecc
wecc merged commit 8d51035 into warp-drive-data:master Jun 23, 2015
@wecc

wecc commented Jun 23, 2015

Copy link
Copy Markdown
Contributor

Thanks!

@pangratz
pangratz deleted the remove_ember-new-computed-dependency branch June 23, 2015 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants