Guard for embedded unknown hasMany relationship - #3126
Conversation
There was a problem hiding this comment.
Is this really what we want? (since the relationship is "unknown")
For other serializers it would make sense to exclude unknown relationships from the payload to prevent overwriting. Might not be necessary for embedded since it should be present, c?
ping @igorT @jakesjews
There was a problem hiding this comment.
I do agree that an embedded relationship should always be present but a developer might not necessarily be in control of the API. An alternative could perhaps be an assert so it's easier to debug.
2a153a6 to
98b96cd
Compare
|
@igorT @jakesjews updated with a warning, still embedding it as an empty array. |
There was a problem hiding this comment.
should probably mention that it's an embedded relationship, and say undefined instead of unknown
|
Thanks! |
98b96cd to
7c21fc8
Compare
7c21fc8 to
d92c6ed
Compare
Guard for embedded unknown hasMany relationship
|
Will this be tagged soon? This is the only thing preventing me from updating my application to Ember v1.12.1. Thanks! |
|
Same here! |
|
Yeah, there have been a lot of changes recently. The plan is to get a release out this week. |
6 participants
Closes #3071