Introduce relationship.hasData - #2936
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
The true argument is not used within the relationships setHasData method ...
Contributor
Author
There was a problem hiding this comment.
@pangratz this was intentional, "future proofing"... we should probably add the parameter to setHasData() method though, even if we currently only support setting it to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first stab at making relationships aware if data exists for the relationship or not.
There's currently no way of knowing if the contents of a relationship is unknown, empty or set just by looking at a snapshot (which is what serializers must do). This PR lays the groundwork of having snapshots returning an unknown state for calls to
.belongsTo()and.hasMany()when we don't know the contents of the relationship yet.This should most likely be reviewed and thought through at least once before we merge it.