feat: enable EdxNotes by default and update related tests

Author: alenkadev

lms/djangoapps/edxnotes/helpers.py

@@ -57,9 +57,11 @@ def get_edxnotes_id_token(user):
     try:
         notes_application = Application.objects.get(name=settings.EDXNOTES_CLIENT_NAME)
     except Application.DoesNotExist:
-        raise ImproperlyConfigured(  # lint-amnesty, pylint: disable=raise-missing-from
-            f'OAuth2 Client with name [{settings.EDXNOTES_CLIENT_NAME}] does not exist.'
+        log.warning(
+            'OAuth2 Client with name [%s] does not exist. EdxNotes will be disabled.',
+            settings.EDXNOTES_CLIENT_NAME
         )
+        return None
     return create_jwt_for_user(
         user, secret=notes_application.client_secret, aud=notes_application.client_id
     )

openedx/core/djangoapps/course_apps/tests/utils.py

@@ -85,11 +85,11 @@ def get_app_tab(self, course_key):
         course = self.store.get_course(course_key)
         return next((tab for tab in course.tabs if tab.type == self.tab_type), None)
 
-    def test_app_disabled_by_default(self):
+    def test_app_enabled_by_default(self):
         """
-        Test that the app tab is disabled by default.
+        Test that the app tab is enabled by default.
         """
-        assert not self.course_app_class.is_enabled(self.course.id)
+        assert self.course_app_class.is_enabled(self.course.id)
 
     def test_app_enabling(self):
         """

xmodule/modulestore/inheritance.py

@@ -210,7 +210,7 @@ class InheritanceMixin(XBlockMixin):
     edxnotes = Boolean(
         display_name=_("Enable Student Notes"),
         help=_("Enter true or false. If true, students can use the Student Notes feature."),
-        default=False,
+        default=True,
         scope=Scope.settings
     )
     edxnotes_visibility = Boolean(

xmodule/tests/test_split_test_block.py

@@ -122,7 +122,7 @@ def setUp(self):
         mocked_modulestore.get_course.return_value = self.course
         self.split_test_block.runtime.modulestore = mocked_modulestore
 
-
+@patch.dict("django.conf.settings.FEATURES", {"ENABLE_EDXNOTES": False})
 @ddt.ddt
 class SplitTestBlockLMSTest(SplitTestBlockTest):
     """
@@ -185,7 +185,7 @@ def test_export_import_round_trip(self, def_to_xml):
         assert fields.get('group_id_to_child') is not None
         assert len(children) == 2
 
-
+@patch.dict("django.conf.settings.FEATURES", {"ENABLE_EDXNOTES": False})
 class SplitTestBlockStudioTest(SplitTestBlockTest):
     """
     Unit tests for how split test interacts with Studio.