Disable cors on master. Cleanup cors configuration on ws-agent - #14921
Merged
Conversation
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
… Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com> Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
requested review from
ibuziuk,
l0rd,
metlos,
mshaposhnik,
nickboldt,
rhopp and
sleshchenko
as code owners
October 18, 2019 07:48
che-bot
added
kind/enhancement
Contributor
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
mshaposhnik
approved these changes
Oct 18, 2019
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
Contributor
|
hello, what's the related issue ? |
Contributor
Author
Contributor
Author
|
ci-test |
Contributor
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
l0rd
approved these changes
Oct 18, 2019
l0rd
left a comment
l0rd
left a comment
Contributor
There was a problem hiding this comment.
I have tested setting CHE_CORS_ENABLED=false and the issue get fixed +1 to merge
skabashnyuk
added a commit
that referenced
this pull request
Oct 22, 2019
* Disable cors on master. Cleanup cors configuration on ws-agent Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
added a commit
that referenced
this pull request
Oct 23, 2019
… (#14952) * Disable cors on master. Cleanup cors configuration on ws-agent Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
n/a
Release Notes
n/a
Docs PR
n/a