Skip to content

[TS-SELENIUM] Adapt WorkspaceCreationAndLsInitialization test according workspace creation from Dashboard changes - #13885

Merged
SkorikSergey merged 3 commits into
masterfrom
fixWorkspaceCreationAndLsInitializationTest
Jul 18, 2019
Merged

[TS-SELENIUM] Adapt WorkspaceCreationAndLsInitialization test according workspace creation from Dashboard changes#13885
SkorikSergey merged 3 commits into
masterfrom
fixWorkspaceCreationAndLsInitializationTest

Conversation

@SkorikSergey

@SkorikSergey SkorikSergey commented Jul 17, 2019

Copy link
Copy Markdown
Contributor

What does this PR do?

According to workspace creation changes(#13825) we need to remove adding project to workspace from WorkspaceCreationAndLsInitialization test (it already added in devfile).

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. team/che-qe labels Jul 17, 2019
@SkorikSergey
SkorikSergey requested a review from dmytro-ndp July 17, 2019 15:46
dmytro-ndp
dmytro-ndp approved these changes Jul 17, 2019
View reviewed changes

@dmytro-ndp dmytro-ndp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dmytro-ndp

dmytro-ndp commented Jul 17, 2019

Copy link
Copy Markdown
Contributor

ci-test

@che-bot

che-bot commented Jul 17, 2019

Copy link
Copy Markdown
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13885
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

rhopp
rhopp suggested changes Jul 18, 2019
View reviewed changes
Comment thread e2e/tests/e2e/WorkspaceCreationAndLsInitialization.spec.ts Outdated

test('Create and open workspace', async () => {
await newWorkspace.createAndRunWorkspace(namespace, workspaceName, 'Java Maven', sampleName);
await newWorkspace.typeWorkspaceName(workspaceName);

@rhopp rhopp Jul 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, that instead of this change, we should change https://github.com/eclipse/che/blob/master/e2e/pageobjects/dashboard/NewWorkspace.ts#L192 (remove the logic of selecting sample)

@SkorikSergey

SkorikSergey commented Jul 18, 2019

Copy link
Copy Markdown
Contributor Author

ci-test

@che-bot

che-bot commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13885
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey

SkorikSergey commented Jul 18, 2019

Copy link
Copy Markdown
Contributor Author

ci-test

@che-bot

che-bot commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13885
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
SkorikSergey merged commit a2fba25 into master Jul 18, 2019
@SkorikSergey
SkorikSergey deleted the fixWorkspaceCreationAndLsInitializationTest branch July 18, 2019 14:33
@vkuznyetsov vkuznyetsov removed the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes
@l0rd l0rd Awaiting requested review from l0rd
@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim
@nickboldt nickboldt Awaiting requested review from nickboldt
@Ohrimenko1988 Ohrimenko1988 Awaiting requested review from Ohrimenko1988
+1 more reviewer
@rhopp rhopp rhopp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SkorikSergey @dmytro-ndp @che-bot @rhopp @vkuznyetsov