Skip to content

Fix the deployment failure with default values.yaml. - #13598

Merged
monaka merged 1 commit into
eclipse-che:masterfrom
PizzaFactory:pr-fix-13448
Jun 27, 2019
Merged

Fix the deployment failure with default values.yaml.#13598
monaka merged 1 commit into
eclipse-che:masterfrom
PizzaFactory:pr-fix-13448

Conversation

@monaka

@monaka monaka commented Jun 21, 2019

Copy link
Copy Markdown
Member

This will fix #13558.

Signed-off-by: Masaki Muranaka monaka@monami-ya.com

What does this PR do?

  • Checks if nil to places referencing che.*.
  • Quotes some URL values

What issues does this PR fix or reference?

Issue

PR

This will fix #13558.

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@monaka
monaka requested review from l0rd and sleshchenko as code owners June 21, 2019 03:13
@che-bot

che-bot commented Jun 21, 2019

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

2 similar comments
@che-bot

che-bot commented Jun 21, 2019

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@che-bot

che-bot commented Jun 21, 2019

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@monaka

monaka commented Jun 21, 2019

Copy link
Copy Markdown
Member Author

I checked this by calling helm lint and helm install --dry-run --debug . with both commented (default) and uncommented vaule.yaml

@musienko-maxim

Copy link
Copy Markdown
Contributor

Can one of the admins verify this PR?

@sleshchenko

Copy link
Copy Markdown
Member

ci-build

@monaka

monaka commented Jun 21, 2019

Copy link
Copy Markdown
Member Author

It looks the test failed at unrelated place...

@skabashnyuk

Copy link
Copy Markdown
Contributor

ci-build

@ssh24

ssh24 commented Jun 21, 2019

Copy link
Copy Markdown

Nice! Thanks for creating the alternative PR @monaka

@monaka
monaka requested a review from skabashnyuk June 25, 2019 04:49
@monaka

monaka commented Jun 26, 2019

Copy link
Copy Markdown
Member Author

Could anybody approve this?

@benoitf

benoitf commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

@skabashnyuk @l0rd @sleshchenko could you please review ?

Comment thread deploy/kubernetes/helm/che/values.yaml
@sleshchenko

Copy link
Copy Markdown
Member

@monaka Thanks for this contribution 👍
Feel free to merge if you test it.

@monaka
monaka merged commit fb41e43 into eclipse-che:master Jun 27, 2019
@monaka
monaka deleted the pr-fix-13448 branch June 27, 2019 08:21
@che-bot che-bot added this to the 7.0.0 milestone Jun 27, 2019
@che-bot che-bot added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to install via helm with default values.yaml.

7 participants