Fix the deployment failure with default values.yaml. - #13598
Merged
Conversation
This will fix #13558. Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
Contributor
|
Can one of the admins verify this patch? |
2 similar comments
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
Can one of the admins verify this patch? |
Member
Author
|
I checked this by calling |
Contributor
|
Can one of the admins verify this PR? |
Member
|
ci-build |
Member
Author
|
It looks the test failed at unrelated place... |
Contributor
|
ci-build |
|
Nice! Thanks for creating the alternative PR @monaka |
Member
Author
|
Could anybody approve this? |
Contributor
|
@skabashnyuk @l0rd @sleshchenko could you please review ? |
sleshchenko
reviewed
Jun 26, 2019
sleshchenko
approved these changes
Jun 27, 2019
Member
|
@monaka Thanks for this contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #13558.
Signed-off-by: Masaki Muranaka monaka@monami-ya.com
What does this PR do?
nilto places referencingche.*.What issues does this PR fix or reference?
Issue
PR