Skip to content

Commit c70317d

Browse files
committed
fix js-sdk test 502 from cleanup function
1 parent e2aed07 commit c70317d

1 file changed

Lines changed: 18 additions & 15 deletions

File tree

packages/js-sdk/tests/sandbox/files/list.test.ts

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,33 +13,40 @@ sandboxTest('list directory', async ({ sandbox }) => {
1313
await sandbox.files.makeDir(`${parentDirName}/subdir1/subdir1_2`)
1414
await sandbox.files.makeDir(`${parentDirName}/subdir2/subdir2_1`)
1515
await sandbox.files.makeDir(`${parentDirName}/subdir2/subdir2_2`)
16+
await sandbox.files.write(`${parentDirName}/file1.txt`, 'Hello, world!')
1617

1718
const testCases = [
1819
{
1920
test_name: 'default depth (1)',
2021
depth: undefined,
21-
expectedLen: 2,
22-
expectedFileNames: ['subdir1', 'subdir2'],
22+
expectedLen: 3,
23+
expectedFileNames: ['file1.txt', 'subdir1', 'subdir2'],
24+
expectedFileTypes: ['file', 'dir', 'dir'],
2325
expectedFilePaths: [
26+
`${homeDirName}/${parentDirName}/file1.txt`,
2427
`${homeDirName}/${parentDirName}/subdir1`,
2528
`${homeDirName}/${parentDirName}/subdir2`,
2629
],
2730
},
2831
{
2932
test_name: 'explicit depth 1',
3033
depth: 1,
31-
expectedLen: 2,
32-
expectedFileNames: ['subdir1', 'subdir2'],
34+
expectedLen: 3,
35+
expectedFileNames: ['file1.txt', 'subdir1', 'subdir2'],
36+
expectedFileTypes: ['file', 'dir', 'dir'],
3337
expectedFilePaths: [
38+
`${homeDirName}/${parentDirName}/file1.txt`,
3439
`${homeDirName}/${parentDirName}/subdir1`,
3540
`${homeDirName}/${parentDirName}/subdir2`,
3641
],
3742
},
3843
{
3944
test_name: 'explicit depth 2',
4045
depth: 2,
41-
expectedLen: 6,
46+
expectedLen: 7,
47+
expectedFileTypes: ['file', 'dir', 'dir', 'dir', 'dir', 'dir', 'dir'],
4248
expectedFileNames: [
49+
'file1.txt',
4350
'subdir1',
4451
'subdir1_1',
4552
'subdir1_2',
@@ -48,6 +55,7 @@ sandboxTest('list directory', async ({ sandbox }) => {
4855
'subdir2_2',
4956
],
5057
expectedFilePaths: [
58+
`${homeDirName}/${parentDirName}/file1.txt`,
5159
`${homeDirName}/${parentDirName}/subdir1`,
5260
`${homeDirName}/${parentDirName}/subdir1/subdir1_1`,
5361
`${homeDirName}/${parentDirName}/subdir1/subdir1_2`,
@@ -59,8 +67,10 @@ sandboxTest('list directory', async ({ sandbox }) => {
5967
{
6068
test_name: 'explicit depth 3 (should be the same as depth 2)',
6169
depth: 3,
62-
expectedLen: 6,
70+
expectedLen: 7,
71+
expectedFileTypes: ['file', 'dir', 'dir', 'dir', 'dir', 'dir', 'dir'],
6372
expectedFileNames: [
73+
'file1.txt',
6474
'subdir1',
6575
'subdir1_1',
6676
'subdir1_2',
@@ -69,6 +79,7 @@ sandboxTest('list directory', async ({ sandbox }) => {
6979
'subdir2_2',
7080
],
7181
expectedFilePaths: [
82+
`${homeDirName}/${parentDirName}/file1.txt`,
7283
`${homeDirName}/${parentDirName}/subdir1`,
7384
`${homeDirName}/${parentDirName}/subdir1/subdir1_1`,
7485
`${homeDirName}/${parentDirName}/subdir1/subdir1_2`,
@@ -87,15 +98,11 @@ sandboxTest('list directory', async ({ sandbox }) => {
8798
assert.equal(files.length, testCase.expectedLen)
8899

89100
for (let i = 0; i < testCase.expectedFilePaths.length; i++) {
90-
assert.equal(files[i].type, 'dir')
101+
assert.equal(files[i].type, testCase.expectedFileTypes[i])
91102
assert.equal(files[i].name, testCase.expectedFileNames[i])
92103
assert.equal(files[i].path, testCase.expectedFilePaths[i])
93104
}
94105
}
95-
96-
onTestFinished(() => {
97-
sandbox.files.remove(parentDirName)
98-
})
99106
})
100107

101108
sandboxTest('list directory with invalid depth', async ({ sandbox }) => {
@@ -111,8 +118,4 @@ sandboxTest('list directory with invalid depth', async ({ sandbox }) => {
111118
`expected error message to include "${expectedErrorMessage}"`
112119
)
113120
}
114-
115-
onTestFinished(() => {
116-
sandbox.files.remove(parentDirName)
117-
})
118121
})

0 commit comments

Comments
 (0)