Skip to content

Commit 9bee7d5

Browse files
Gerrit User 1184479Gerrit Code Review
authored andcommitted
Update patch set 4
Patch Set 4: Sorry, but this is not the way to do that. Registry key approach was discussed downstream in nodejs, Heath Stewart who is responsible for the VS installer said explicitly that the registry entry is not supported (nodejs/node-gyp#1103 (comment)) In node-gyp we used Rafael's powershell script that can query VS COM server (nodejs/node-gyp#1130). We used that to find VS and set environment variables. IMHO we should do the same thing here. Patch-set: 4
1 parent 2bfe6f7 commit 9bee7d5

0 file changed

File tree

    0 commit comments

    Comments
     (0)