Commit 5db5f9b
committed
feat(telemetry): Phase 4a — TTFT capture + GenAI semconv dual-emit (QwenLM#3731)
Adds time-to-first-token measurement and OTel GenAI semantic convention
dual-emit to the qwen-code.llm_request span. First slice of Phase 4 LLM
request timing decomposition (sub-issue QwenLM#4413).
Builds on Phase 1 (QwenLM#4126), Phase 1.5 (QwenLM#4302), Phase 2 (QwenLM#4321). Self-contained
— ships TTFT visibility without depending on the Phase 4b retry-callback work.
Changes
-------
- New hasUserVisibleContent(chunk) helper centralizes "is this chunk first
user-visible output" detection across all 4 providers. Operates on the
normalized GenerateContentResponse shape each provider emits before
LoggingContentGenerator sees the stream. Recognizes text / functionCall /
inlineData / executableCode / thought parts; skips role-only and
usageMetadata-only chunks.
- TTFT capture in LoggingContentGenerator.generateContentStream's stream
wrapper. Method-local closure variable, NEVER instance field — the
generator is one-per-ContentGenerator and shared across concurrent calls
(subagent fan-out, warmup, side-queries).
- Extends LLMRequestMetadata with: ttftMs, requestSetupMs, attempt,
retryTotalDelayMs, cachedInputTokens. The first is populated in 4a; the
middle three are declared as optional so Phase 4b's retry callback can
populate them without touching the schema again.
- endLLMRequestSpan writes new span attrs: ttft_ms, sampling_ms (derived:
duration - ttft - requestSetup, clamped to >= 0), output_tokens_per_second
(derived: outputTokens / (sampling_ms / 1000), omitted when sampling_ms == 0
to avoid divide-by-zero, rounded to 2 decimals), cached_input_tokens,
plus Phase 4b placeholders (attempt, request_setup_ms, retry_total_delay_ms)
when caller provides them.
- GenAI semconv dual-emit. Private qwen-code names stay authoritative
(dashboards, SLOs, ARMS queries reference these); semconv is a compat
layer for spec-aware backends. Same pattern as Phase 3 (QwenLM#4410):
qwen-code.model + gen_ai.request.model (Stable)
input_tokens + gen_ai.usage.input_tokens (Stable)
output_tokens + gen_ai.usage.output_tokens (Stable)
cached_input_tokens + gen_ai.usage.cached_tokens (Experimental)
ttft_ms (ms, int) + gen_ai.server.time_to_first_token
(s, double, Experimental)
TTFT semantic intentionally diverges from claude-code's ttftMs (which fires
on Anthropic's message_start metadata event). qwen-code measures "first
user-visible content" — uniform across Anthropic / OpenAI / Gemini / Qwen,
matches the literal "first token" intent. See design doc D1 for rationale.
Design doc
----------
docs/design/telemetry-llm-request-timing-design.md (~530 lines) covers all
7 locked decisions with "Why not X" justifications, lifecycle wiring for
streaming + non-streaming + 4 retry sites, files-to-change table with LOC
estimates, test strategy, edge cases, rollback plan, and a comparison with
claude-code (full decomposition but only for Perfetto) and opencode
(no TTFT measurement at all).
Tests
-----
- streamContentDetection.test.ts (13 tests) covers part types matrix.
- session-tracing.test.ts +16 tests (new describe block) cover dual-emit
for every gen_ai.* field, sampling_ms clamping at 0 for clock skew,
output_tokens_per_second rounding + divide-by-zero, Phase 4b
placeholder fields written when present, absent when not.
- loggingContentGenerator.test.ts +4 tests cover TTFT capture in
streaming, undefined when stream yields only metadata chunks, and
cachedInputTokens forwarding from usageMetadata on both stream and
non-stream paths.
All 448 telemetry tests pass, tsc --noEmit clean, eslint clean.
Phase 4b (retry callback + ApiRetryEvent) and Phase 4c
(recordApiRequestBreakdown activation) follow in separate PRs per the
design doc split.
🤖 Generated with [Qwen Code](https://github.com/QwenLM/qwen-code)1 parent 48b0a8b commit 5db5f9b
7 files changed
Lines changed: 1148 additions & 2 deletions
File tree
- docs/design
- packages/core/src
- core/loggingContentGenerator
- telemetry
Large diffs are not rendered by default.
Lines changed: 149 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
168 | 173 | | |
169 | 174 | | |
170 | 175 | | |
| |||
616 | 621 | | |
617 | 622 | | |
618 | 623 | | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
619 | 768 | | |
620 | 769 | | |
621 | 770 | | |
| |||
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
285 | 286 | | |
286 | 287 | | |
287 | 288 | | |
| 289 | + | |
288 | 290 | | |
289 | 291 | | |
290 | 292 | | |
| |||
462 | 464 | | |
463 | 465 | | |
464 | 466 | | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
465 | 475 | | |
466 | 476 | | |
467 | 477 | | |
| |||
516 | 526 | | |
517 | 527 | | |
518 | 528 | | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
519 | 536 | | |
520 | 537 | | |
521 | 538 | | |
| |||
601 | 618 | | |
602 | 619 | | |
603 | 620 | | |
| 621 | + | |
| 622 | + | |
604 | 623 | | |
605 | 624 | | |
606 | 625 | | |
| |||
Lines changed: 108 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
Lines changed: 54 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
0 commit comments