[cDAC] Attach each stress log to its per-debuggee test sub-result

The legacy Helix->ADO reporter models a [Theory] as a single test result with one
sub-result per data row. Attaching all logs to the parent result put them on the
top-level test instead of each debuggee's run. Parse the debuggee from each
sub-result's display name (debuggeeName) and attach that debuggee's log to the
matching sub-result via testSubResultId; single-row theories (Windows-only
PInvoke) attach to the result directly. Unmapped logs fall back to run level.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Max Charlamb

eng/pipelines/cdac/attach-cdac-stress-logs.ps1

@@ -16,9 +16,12 @@
       1. Finds this leg's test run for the build (matched by the unique
          TestRunNamePrefix set in cdac-stress-helix.proj).
       2. Extracts the per-debuggee logs from the downloaded tarball.
-      3. Attaches each log to the run's GCStress test result(s) via the Azure
-         DevOps Test Attachments REST API (falling back to a run-level attachment
-         if no matching result is found).
+      3. Attaches each log to its own per-debuggee test result. The legacy
+         reporter models a [Theory] as one result with a sub-result per data row,
+         so each debuggee's log is attached to its sub-result (via
+         testSubResultId); single-row theories are attached to the result itself.
+         Anything that can't be mapped is attached at the run level so no log is
+         lost.
 
     Failures here are non-fatal: the build artifact remains the source of truth,
     so the script logs warnings and always exits 0.
@@ -104,42 +107,89 @@ try {
         return $name
     }
 
+    # Pull the debuggee name out of an xUnit display name like
+    # '...GCStress_AllVerificationsPass(debuggeeName: "BasicAlloc")'.
+    function Get-Debuggee([string]$name) {
+        if ([string]::IsNullOrEmpty($name)) { return $null }
+        $m = [regex]::Match($name, 'debuggeeName:\s*\\?"(?<d>[^"\\]+)')
+        if ($m.Success) { return $m.Groups['d'].Value }
+        return $null
+    }
+
+    # Map each downloaded log to its debuggee (case-insensitive) so we can attach
+    # it to the matching per-debuggee test result / sub-result.
+    $logByDebuggee = @{}
+    foreach ($log in $logFiles) {
+        $m = [regex]::Match($log.Name, '^cdac-gcstress-(?<d>.+?)-[0-9a-fA-F]{32}\.txt$')
+        if ($m.Success) { $logByDebuggee[$m.Groups['d'].Value.ToLowerInvariant()] = $log }
+    }
+
     foreach ($run in $matchingRuns) {
         $runId = $run.id
         $resultsUri = "$baseUrl/_apis/test/runs/$runId/results?api-version=7.1"
         $results = Invoke-RestMethod -Headers $headers -Uri $resultsUri -Method Get
         $gcStressResults = @($results.value | Where-Object { $_.automatedTestName -match 'GCStress' })
 
         $attached = 0
-        if ($gcStressResults.Count -gt 0) {
-            # Attach every log to each GCStress result so they appear in the
-            # result's Attachments pane (the data-driven theory collapses to a
-            # single result, so over-attaching is both harmless and complete).
-            foreach ($res in $gcStressResults) {
-                $uri = "$baseUrl/_apis/test/Runs/$runId/Results/$($res.id)/attachments?api-version=$apiVer"
-                foreach ($log in $logFiles) {
+        $usedDebuggees = New-Object 'System.Collections.Generic.HashSet[string]'
+
+        # Attach each debuggee's log to its own test result. The legacy reporter
+        # models a [Theory] as a single result with one sub-result per data row,
+        # so the per-debuggee runs are sub-results (attach via testSubResultId).
+        # A single-row theory (e.g. the Windows-only PInvoke case) stays as a
+        # standalone result with the arg in its name (attach to the result).
+        foreach ($res in $gcStressResults) {
+            $detail = Invoke-RestMethod -Headers $headers -Uri "$baseUrl/_apis/test/runs/$runId/results/$($res.id)?detailsToInclude=SubResults&api-version=7.1" -Method Get
+            $subs = @($detail.subResults)
+
+            if ($subs.Count -gt 0) {
+                foreach ($sub in $subs) {
+                    $d = Get-Debuggee $sub.displayName
+                    if ($d -and $logByDebuggee.ContainsKey($d.ToLowerInvariant())) {
+                        $log = $logByDebuggee[$d.ToLowerInvariant()]
+                        $uri = "$baseUrl/_apis/test/Runs/$runId/Results/$($res.id)/attachments?testSubResultId=$($sub.id)&api-version=$apiVer"
+                        try {
+                            Add-Attachment -uri $uri -fileName "$d.txt" -filePath $log.FullName
+                            $attached++; [void]$usedDebuggees.Add($d.ToLowerInvariant())
+                        } catch {
+                            Write-Warn "Failed to attach '$($log.Name)' to run $runId result $($res.id) sub $($sub.id): $($_.Exception.Message)"
+                        }
+                    } else {
+                        Write-Warn "No log found for sub-result debuggee '$d' (result $($res.id))."
+                    }
+                }
+            } else {
+                $d = Get-Debuggee $res.automatedTestName
+                if ($d -and $logByDebuggee.ContainsKey($d.ToLowerInvariant())) {
+                    $log = $logByDebuggee[$d.ToLowerInvariant()]
+                    $uri = "$baseUrl/_apis/test/Runs/$runId/Results/$($res.id)/attachments?api-version=$apiVer"
                     try {
-                        Add-Attachment -uri $uri -fileName (Get-CleanName $log.Name) -filePath $log.FullName
-                        $attached++
+                        Add-Attachment -uri $uri -fileName "$d.txt" -filePath $log.FullName
+                        $attached++; [void]$usedDebuggees.Add($d.ToLowerInvariant())
                     } catch {
                         Write-Warn "Failed to attach '$($log.Name)' to run $runId result $($res.id): $($_.Exception.Message)"
                     }
                 }
             }
-            Write-Info "Run $runId ('$($run.name)'): attached $attached log(s) across $($gcStressResults.Count) GCStress result(s)."
-        } else {
-            # Fallback: attach at the run level.
-            $uri = "$baseUrl/_apis/test/Runs/$runId/attachments?api-version=$apiVer"
-            foreach ($log in $logFiles) {
+        }
+
+        # Fallback: any log we couldn't map to a result/sub-result (e.g. a
+        # debuggee that crashed before producing a result) is attached at the run
+        # level so nothing is silently lost.
+        foreach ($kv in $logByDebuggee.GetEnumerator()) {
+            if (-not $usedDebuggees.Contains($kv.Key)) {
+                $uri = "$baseUrl/_apis/test/Runs/$runId/attachments?api-version=$apiVer"
                 try {
-                    Add-Attachment -uri $uri -fileName (Get-CleanName $log.Name) -filePath $log.FullName
+                    Add-Attachment -uri $uri -fileName (Get-CleanName $kv.Value.Name) -filePath $kv.Value.FullName
                     $attached++
+                    Write-Warn "Debuggee '$($kv.Key)' had no matching test result; attached '$($kv.Value.Name)' at run level."
                 } catch {
-                    Write-Warn "Failed to attach '$($log.Name)' to run ${runId}: $($_.Exception.Message)"
+                    Write-Warn "Failed to attach unmatched '$($kv.Value.Name)' to run ${runId}: $($_.Exception.Message)"
                 }
             }
-            Write-Info "Run $runId ('$($run.name)'): no GCStress result found; attached $attached log(s) at run level."
         }
+
+        Write-Info "Run $runId ('$($run.name)'): attached $attached log(s) ($($usedDebuggees.Count) mapped to per-debuggee results)."
     }
 }
 catch {