Skip to content

Commit 0e0694f

Browse files
steveisokCopilot
andcommitted
Disable F# test project signing unconditionally
The F# compiler produces assemblies with malformed public key blobs when public-signing with full key pairs on Unix (dotnet/fsharp#19441). Previously SignAssembly was only disabled for source-build, but the fix for dotnet/fsharp#19242 exposed this on all Unix legs. Since this is a non-shipping test project, disable signing unconditionally as a workaround. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 77de348 commit 0e0694f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/libraries/System.Formats.Cbor/tests/CborDocument/System.Formats.Cbor.Tests.DataModel.fsproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
55
<!-- NuGet restore issue with TargetFrameworks in f# projects: https://github.com/NuGet/Home/issues/10005 -->
66
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
7-
<!-- Public signing (performed under DotNetBuildSourceOnly) is broken for f#: https://github.com/dotnet/fsharp/issues/17451 -->
8-
<SignAssembly Condition="'$(DotNetBuildSourceOnly)' == 'true'">false</SignAssembly>
7+
<!-- F# public signing with full key pairs produces malformed public key blobs on Unix: https://github.com/dotnet/fsharp/issues/19441 -->
8+
<SignAssembly>false</SignAssembly>
99
</PropertyGroup>
1010

1111
<ItemGroup>

0 commit comments

Comments
 (0)