Anonymous record support for expressions in FCS (#6257)

* fix flakey test (?)

* use runsettings

* same fix for FCS tests2

* anonymous record support for expressions in FCS

* anonymous record support for expressions in FCS

* add tests for anonymous records and fix service testing with F# interactive

* fix FCS docs

* fix build

* add diagnostics

* update other baseline

* fix final parallel case

* try again to fix test

* update test fixes

Author: dsyme

fcs/docsrc/content/caches.fsx

@@ -1,5 +1,5 @@
 (*** hide ***)
-#I "../../bin/v4.5/"
+#I "../../../artifacts/bin/fcs/net45"
 (**
 Compiler Services: Notes on the FSharpChecker caches
 =================================================

fcs/docsrc/content/compiler.fsx

@@ -1,5 +1,5 @@
 (*** hide ***)
-#I "../../bin/v4.5/"
+#I "../../../artifacts/bin/fcs/net45"
 (**
 Hosted Compiler
 ===============
@@ -55,7 +55,9 @@ let x = 3 + 4
 Now invoke the compiler:
 *)
 
-let errors1, exitCode1 = checker.Compile([| "fsc.exe"; "-o"; fn3; "-a"; fn2 |])
+let errors1, exitCode1 = 
+    checker.Compile([| "fsc.exe"; "-o"; fn3; "-a"; fn2 |]) 
+    |> Async.RunSynchronously
 
 (** 
 
@@ -68,7 +70,9 @@ module M
 let x = 1.0 + "" // a type error
 """)
 
-let errors1b, exitCode1b = checker.Compile([| "fsc.exe"; "-o"; fn3; "-a"; fn2 |])
+let errors1b, exitCode1b = 
+    checker.Compile([| "fsc.exe"; "-o"; fn3; "-a"; fn2 |])
+    |> Async.RunSynchronously
 
 (**
 
@@ -85,10 +89,12 @@ The 'None' option indicates that the initiatlization code for the assembly is no
 *)
 let errors2, exitCode2, dynAssembly2 = 
     checker.CompileToDynamicAssembly([| "-o"; fn3; "-a"; fn2 |], execute=None)
+     |> Async.RunSynchronously
 
 (*
 Passing 'Some' for the 'execute' parameter executes  the initiatlization code for the assembly.
 *)
 let errors3, exitCode3, dynAssembly3 = 
     checker.CompileToDynamicAssembly([| "-o"; fn3; "-a"; fn2 |], Some(stdout,stderr))
+     |> Async.RunSynchronously
 

fcs/docsrc/content/corelib.fsx

@@ -1,5 +1,5 @@
 (*** hide ***)
-#I "../../bin/v4.5/"
+#I "../../../artifacts/bin/fcs/net45"
 (**
 Compiler Services: Notes on FSharp.Core.dll
 =================================================
@@ -13,14 +13,11 @@ include a copy of FSharp.Core.dll as part of your application.
 For example, if you build a ``HostedCompiler.exe``, you will normally place an FSharp.Core.dll (say 4.3.1.0) alongside
 your ``HostedCompiler.exe``.  
 
-If doing dynamic compilation and execution you may also need to include 
-an FSharp.Core.optdata and FSharp.Core.sigdata, see below for guidance.
-
 Binding redirects for your application
 --------------------------------------
 
 The FSharp.Compiler.Service.dll component depends on FSharp.Core 4.4.0.0.  Normally your application will target
-a later version of FSharp.Core, and you will need a [binding redirect](http://msdn.microsoft.com/en-us/library/7wd6ex19(v=vs.110).aspx) to ensure
+a later version of FSharp.Core, and you may need a [binding redirect](http://msdn.microsoft.com/en-us/library/7wd6ex19(v=vs.110).aspx) to ensure
 that other versions of FSharp.Core forward to the final version of FSharp.Core.dll your application uses.
 Binding redirect files are normally generated automatically by build tools. If not, you can use one like this
 (if your tool is called ``HostedCompiler.exe``, the binding redirect file is called ``HostedCompiler.exe.config``)
@@ -80,27 +77,12 @@ by the following choice:
 
 2. If there is no static reference to FSharp.Core in the host assembly, then 
 
-   - For FSharp.Compiler.Service 0.x series, a reference to FSharp.Core version 4.3.0.0 is added
-
-   - For FSharp.Compiler.Service 1.3.1.x (F# 3.1 series), a reference to FSharp.Core version 4.3.1.0 is added
-
-   - For FSharp.Compiler.Service 1.4.0.x (F# 4.0 series), a reference to FSharp.Core version 4.4.0.0 is added
+   - For FSharp.Compiler.Service 1.4.0.x above (F# 4.0 series), a reference to FSharp.Core version 4.4.0.0 is added
 
 Do I need to include FSharp.Core.optdata and FSharp.Core.sigdata?
 --------------------------------------
 
-If your compilation arguments explicitly reference an FSharp.Core.dll from an SDK location, then FSharp.Core.sigdata and FSharp.Core.optdata should be alongside the DLL
-(if these files are not installed, then that's a bug in the F# SDK installation).  If your compilation
-arguments are always making an explicit reference, then you should _not_ include FSharp.Core.optdata and FSharp.Core.sigdata as part of your application.
-
-If you are relying on an implicit reference (e.g. for script processing, see above), this means your tool may reference the FSharp.Core.dll
-that is part of your application.  In this case, you may either get an error that FSharp.Core.optdata and FSharp.Core.sigdata are not
-found alongside FSharp.Core.dll.  **If you want to implicitly reference the FSharp.Core.dll you are including in your application,
-then also add FSharp.Core.sigdata and FSharp.Core.optdata as two additional files to your application**.  When using ``CompileToDynamicAssembly``, this problem
-can also manifest itself as [a stack overflow during assembly resolution](https://github.com/fsharp/FSharp.Compiler.Service/issues/258).
-
-Tools that dynamically compile and execute code (e.g. a ``HostedExecution.exe``) often make an implicit 
-reference to FSharp.Core.dll, which means they normally also include FSharp.Core.optdata and FSharp.Core.sigdata.
+No, unless you are doing something with very old FSharp.Core.dll.
 
 Summary
 -------

fcs/docsrc/content/editor.fsx

@@ -1,5 +1,5 @@
 (*** hide ***)
-#I "../../bin/v4.5/"
+#I "../../../artifacts/bin/fcs/net45"
 (**
 Compiler Services: Editor services
 ==================================
@@ -52,7 +52,7 @@ let input =
 let inputLines = input.Split('\n')
 let file = "/home/user/Test.fsx"
 
-let projOptions = 
+let projOptions, errors = 
     checker.GetProjectOptionsFromScript(file, input)
     |> Async.RunSynchronously
 
@@ -131,7 +131,7 @@ open FSharp.Compiler
 let identToken = FSharpTokenTag.Identifier
 
 // Get tool tip at the specified location
-let tip = checkFileResults.GetToolTipTextAlternate(4, 7, inputLines.[1], ["foo"], identToken)
+let tip = checkFileResults.GetToolTipText(4, 7, inputLines.[1], ["foo"], identToken)
 printfn "%A" tip
 
 (**
@@ -165,7 +165,7 @@ where we need to perform the completion.
 // Get declarations (autocomplete) for a location
 let decls = 
     checkFileResults.GetDeclarationListInfo
-      (Some parseFileResults, 7, 23, inputLines.[6], [], "msg", fun _ -> false)
+      (Some parseFileResults, 7, inputLines.[6], PartialLongName.Empty 23, (fun () -> []), fun _ -> false)
     |> Async.RunSynchronously
 
 // Print the names of available items
@@ -197,7 +197,7 @@ changes):
 *)
 // Get overloads of the String.Concat method
 let methods = 
-    checkFileResults.GetMethodsAlternate(5, 27, inputLines.[4], Some ["String"; "Concat"])
+    checkFileResults.GetMethods(5, 27, inputLines.[4], Some ["String"; "Concat"])
     |> Async.RunSynchronously
 
 // Print concatenated parameter lists

fcs/docsrc/content/filesystem.fsx

@@ -1,5 +1,5 @@
 (*** hide ***)
-#I "../../bin/v4.5/"
+#I "../../../artifacts/bin/fcs/net45"
 (**
 Compiler Services: Virtualized File System
 ==========================================
@@ -59,25 +59,34 @@ let B = File1.A + File1.A"""
         // Implement the service related to temporary paths and file time stamps
         member __.GetTempPathShim() = 
             defaultFileSystem.GetTempPathShim()
+
         member __.GetLastWriteTimeShim(fileName) = 
             defaultFileSystem.GetLastWriteTimeShim(fileName)
+
         member __.GetFullPathShim(fileName) = 
             defaultFileSystem.GetFullPathShim(fileName)
+
         member __.IsInvalidPathShim(fileName) = 
             defaultFileSystem.IsInvalidPathShim(fileName)
+
         member __.IsPathRootedShim(fileName) = 
             defaultFileSystem.IsPathRootedShim(fileName)
 
+        member __.IsStableFileHeuristic(fileName) = 
+            defaultFileSystem.IsStableFileHeuristic(fileName)
+
         // Implement the service related to file existence and deletion
         member __.SafeExists(fileName) = 
             files.ContainsKey(fileName) || defaultFileSystem.SafeExists(fileName)
+
         member __.FileDelete(fileName) = 
             defaultFileSystem.FileDelete(fileName)
 
         // Implement the service related to assembly loading, used to load type providers
         // and for F# interactive.
         member __.AssemblyLoadFrom(fileName) = 
             defaultFileSystem.AssemblyLoadFrom fileName
+
         member __.AssemblyLoad(assemblyName) = 
             defaultFileSystem.AssemblyLoad assemblyName 
 
@@ -131,7 +140,11 @@ let projectOptions =
                  yield "-r:" + r |]
 
     { ProjectFileName = @"c:\mycode\compilation.fsproj" // Make a name that is unique in this directory.
-      ProjectFileNames = [| fileName1; fileName2 |]
+      ProjectId = None
+      SourceFiles = [| fileName1; fileName2 |]
+      OriginalLoadReferences = []
+      ExtraProjectInfo=None
+      Stamp = None
       OtherOptions = allFlags 
       ReferencedProjects = [| |]
       IsIncompleteTypeCheckEnvironment = false

fcs/docsrc/content/interactive.fsx

@@ -1,5 +1,5 @@
 (*** hide ***)
-#I "../../bin/v4.5/"
+#I "../../../artifacts/bin/fcs/net45"
 (**
 Interactive Service: Embedding F# Interactive
 =============================================
@@ -211,7 +211,9 @@ fsiSession.EvalInteraction "let xxx = 1 + 1"
 Now you want to typecheck the partially complete code `xxx + xx`
 *)
 
-let parseResults, checkResults, checkProjectResults = fsiSession.ParseAndCheckInteraction("xxx + xx")
+let parseResults, checkResults, checkProjectResults = 
+    fsiSession.ParseAndCheckInteraction("xxx + xx")
+    |> Async.RunSynchronously
 
 (** 
 The `parseResults` and `checkResults` have types `ParseFileResults` and `CheckFileResults`
@@ -228,7 +230,7 @@ You can also request declaration list information, tooltip text and symbol resol
 open FSharp.Compiler
 
 // get a tooltip
-checkResults.GetToolTipTextAlternate(1, 2, "xxx + xx", ["xxx"], FSharpTokenTag.IDENT) 
+checkResults.GetToolTipText(1, 2, "xxx + xx", ["xxx"], FSharpTokenTag.IDENT) 
 
 checkResults.GetSymbolUseAtLocation(1, 2, "xxx + xx", ["xxx"]) // symbol xxx
 

fcs/docsrc/content/ja/compiler.fsx

@@ -1,5 +1,5 @@
 (*** hide ***)
-#I "../../../../debug/bin/net45/"
+#I "../../../../artifacts/bin/fcs/net45"
 (**
 コンパイラの組み込み
 ====================
@@ -18,10 +18,10 @@
 *)
 
 #r "FSharp.Compiler.Service.dll"
-open FSharp.Compiler.SimpleSourceCodeServices
+open FSharp.Compiler.SourceCodeServices
 open System.IO
 
-let scs = SimpleSourceCodeServices()
+let scs = FSharpChecker.Create()
 
 (**
 次に、一時ファイルへコンテンツを書き込みます:
@@ -44,7 +44,7 @@ let x = 3 + 4
 そしてコンパイラを呼び出します:
 *)
 
-let errors1, exitCode1 = scs.Compile([| "fsc.exe"; "-o"; fn3; "-a"; fn2 |])
+let errors1, exitCode1 = scs.Compile([| "fsc.exe"; "-o"; fn3; "-a"; fn2 |]) |> Async.RunSynchronously
 
 (** 
 
@@ -57,7 +57,7 @@ module M
 let x = 1.0 + "" // a type error
 """)
 
-let errors1b, exitCode1b = scs.Compile([| "fsc.exe"; "-o"; fn3; "-a"; fn2 |])
+let errors1b, exitCode1b = scs.Compile([| "fsc.exe"; "-o"; fn3; "-a"; fn2 |]) |> Async.RunSynchronously
 
 if exitCode1b <> 0 then
     errors1b
@@ -79,11 +79,11 @@ if exitCode1b <> 0 then
 'execute' 引数に 'None' を指定するとアセンブリ用の初期化コードが実行されません。
 *)
 let errors2, exitCode2, dynAssembly2 = 
-    scs.CompileToDynamicAssembly([| "-o"; fn3; "-a"; fn2 |], execute=None)
+    scs.CompileToDynamicAssembly([| "-o"; fn3; "-a"; fn2 |], execute=None) |> Async.RunSynchronously
 
 (**
 'Some' を指定するとアセンブリ用の初期化コードが実行されます。
 *)
 let errors3, exitCode3, dynAssembly3 = 
-    scs.CompileToDynamicAssembly([| "-o"; fn3; "-a"; fn2 |], Some(stdout,stderr))
+    scs.CompileToDynamicAssembly([| "-o"; fn3; "-a"; fn2 |], Some(stdout,stderr)) |> Async.RunSynchronously
 

fcs/docsrc/content/ja/corelib.fsx

@@ -1,5 +1,5 @@
 (*** hide ***)
-#I "../../bin/v4.5/"
+#I "../../../../artifacts/bin/fcs/net45"
 (**
 コンパイラサービス: FSharp.Core.dll についてのメモ
 ==================================================