Fix phantom schema diff for float columns with default values (#7501)

Author: HypeMC

src/Platforms/AbstractPlatform.php

@@ -1597,6 +1597,10 @@ public function getDefaultValueDeclarationSQL(array $column): string
             return ' DEFAULT ' . $default;
         }
 
+        if ($type instanceof Types\PhpFloatMappingType) {
+            return ' DEFAULT ' . (float) $default;
+        }
+
         return ' DEFAULT ' . $this->quoteStringLiteral($default);
     }
 

src/Types/FloatType.php

@@ -6,7 +6,7 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 
-class FloatType extends Type
+class FloatType extends Type implements PhpFloatMappingType
 {
     /**
      * {@inheritDoc}

src/Types/PhpFloatMappingType.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\DBAL\Types;
+
+/**
+ * Implementations should map a database type to a PHP float.
+ *
+ * @internal
+ */
+interface PhpFloatMappingType
+{
+}

src/Types/SmallFloatType.php

@@ -6,7 +6,7 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 
-class SmallFloatType extends Type
+class SmallFloatType extends Type implements PhpFloatMappingType
 {
     /**
      * {@inheritDoc}

tests/Functional/Schema/ComparatorTest.php

@@ -8,6 +8,7 @@
 use Doctrine\DBAL\Platforms\MariaDBPlatform;
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
 use Doctrine\DBAL\Schema\Column;
+use Doctrine\DBAL\Schema\ColumnEditor;
 use Doctrine\DBAL\Schema\Comparator;
 use Doctrine\DBAL\Schema\ComparatorConfig;
 use Doctrine\DBAL\Schema\Name\UnqualifiedName;
@@ -17,6 +18,7 @@
 use Doctrine\DBAL\Types\Type;
 use Doctrine\DBAL\Types\Types;
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\TestWith;
 
 class ComparatorTest extends FunctionalTestCase
 {
@@ -61,6 +63,46 @@ public function testDefaultValueComparison(string $typeName, mixed $value): void
         );
     }
 
+    #[TestWith([Types::FLOAT])]
+    #[TestWith([Types::SMALLFLOAT])]
+    public function testFloatDefaultValueComparisonConverges(string $typeName): void
+    {
+        $table = Table::editor()
+            ->setUnquotedName('float_default_value')
+            ->setColumns(
+                Column::editor()
+                    ->setUnquotedName('score')
+                    ->setTypeName($typeName)
+                    ->setDefaultValue(14.75)
+                    ->create(),
+            )
+            ->create();
+
+        $this->dropAndCreateTable($table);
+
+        $comparator = $this->schemaManager->createComparator();
+
+        self::assertTrue(ComparatorTestUtils::diffFromActualToDesiredTable(
+            $this->schemaManager,
+            $comparator,
+            $table,
+        )->isEmpty());
+
+        self::assertTrue(ComparatorTestUtils::diffFromDesiredToActualTable(
+            $this->schemaManager,
+            $comparator,
+            $table,
+        )->isEmpty());
+
+        $desiredTable = $table->edit()
+            ->modifyColumnByUnquotedName('score', static function (ColumnEditor $editor): void {
+                $editor->setDefaultValue(50.0);
+            })
+            ->create();
+
+        ComparatorTestUtils::assertDiffNotEmpty($this->connection, $comparator, $desiredTable);
+    }
+
     public function testRenameColumnComparison(): void
     {
         $platform   = $this->connection->getDatabasePlatform();
@@ -147,6 +189,9 @@ public static function defaultValueProvider(): iterable
     {
         return [
             [Types::INTEGER, 1],
+            [Types::FLOAT, 14.75],
+            [Types::FLOAT, '50.0'],
+            [Types::SMALLFLOAT, 14.75],
             [Types::BOOLEAN, false],
             [Types::TEXT, 'Doctrine'],
         ];