Skip to content

Commit 6a8a370

Browse files
committed
refactor(VIcon): ♻️ supprime le mock @iconify/vue redondant dans les tests
- Le mock de `@iconify/vue` était déclaré deux fois dans `VIcon.spec.ts` : une fois au niveau du module (`vi.mock`) et une seconde fois dans un `beforeEach`, ce qui n’apportait rien et alourdissait le fichier - Suppression du `beforeEach` qui redéclarait le mock `@iconify/vue` - Suppression de l’import `beforeEach` devenu inutilisé
1 parent a44ab7d commit 6a8a370

3 files changed

Lines changed: 4 additions & 13 deletions

File tree

.storybook/main.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ const config: StorybookConfigWithPreviewAnnotations = {
5252
config.customLogger = {
5353
...baseLogger,
5454
warn (msg, options) {
55-
if (typeof msg === 'string' && msg.includes('decodeEntities option is passed but will be ignored in non-browser builds')) {
55+
const text = typeof msg === 'string' ? msg : msg instanceof Error ? msg.message : String(msg)
56+
if (text.includes('decodeEntities option is passed but will be ignored in non-browser builds')) {
5657
return
5758
}
5859
baseLogger.warn(msg, options)

src/components/VIcon/VIcon.spec.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { IconifyJSON } from '@iconify/vue'
22

33
import { flushPromises, mount } from '@vue/test-utils'
4-
import { beforeEach, describe, expect, it, vi } from 'vitest'
4+
import { describe, expect, it, vi } from 'vitest'
55

66
import { vueDsfrIconCollectionsKey, vueDsfrPreferOfflineIconsKey } from '../VIconOffline/injection-key'
77

@@ -18,16 +18,6 @@ vi.mock('@iconify/vue', () => ({
1818
}))
1919

2020
describe('VIcon', () => {
21-
beforeEach(() => {
22-
vi.mock('@iconify/vue', () => ({
23-
Icon: {
24-
name: 'MockedIcon',
25-
props: ['icon', 'ssr', 'style', 'aria-label', 'flip'],
26-
template: '<div data-testid="mocked-icon"></div>',
27-
},
28-
}))
29-
})
30-
3121
describe('Gestion de l\'hydratation', () => {
3222
it('devrait afficher un fallback pendant l\'hydratation quand ssr=true', async () => {
3323
const wrapper = mount(VIcon, {

vitest.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { playwright } from '@vitest/browser-playwright'
55
import { mergeConfig } from 'vite'
66
import { configDefaults, defineConfig } from 'vitest/config'
77

8-
import viteConfig from './vite.config'
8+
import viteConfig from './vite.config.ts'
99

1010
// More info at: https://storybook.js.org/docs/next/writing-tests/integrations/vitest-addon
1111
export default mergeConfig(viteConfig, defineConfig({

0 commit comments

Comments
 (0)