Skip to content

Commit d0cc0bd

Browse files
authored
Removed conflicting or redundant children props (#2172)
* Removed conflicting or redundant children props * Removed PropsWithChildren from Canvas and Image * changeset
1 parent 7b0c740 commit d0cc0bd

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

.changeset/young-students-allow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@react-pdf/renderer': patch
3+
---
4+
5+
Improved `children` prop types for react@18.

packages/renderer/index.d.ts

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ declare namespace ReactPDF {
2929
language?: string;
3030
pdfVersion?: PDFVersion;
3131
onRender?: (props: OnRenderProps) => any;
32-
children?: React.ReactNode;
3332
}
3433

3534
/**
@@ -76,7 +75,6 @@ declare namespace ReactPDF {
7675
orientation?: Orientation;
7776
dpi?: number;
7877
bookmark?: Bookmark;
79-
children?: React.ReactNode;
8078
}
8179

8280
/**
@@ -103,7 +101,6 @@ declare namespace ReactPDF {
103101
pageNumber: number;
104102
subPageNumber: number;
105103
}) => React.ReactNode;
106-
children?: React.ReactNode;
107104
}
108105

109106
/**
@@ -135,7 +132,7 @@ declare namespace ReactPDF {
135132
* A React component for displaying network or local (Node only) JPG or
136133
* PNG images, as well as base64 encoded image strings.
137134
*/
138-
class Image extends React.Component<React.PropsWithChildren<ImageProps>> {}
135+
class Image extends React.Component<ImageProps> {}
139136

140137
interface TextProps extends NodeProps {
141138
id?: string;
@@ -155,7 +152,6 @@ declare namespace ReactPDF {
155152
subPageNumber: number;
156153
subPageTotalPages: number;
157154
}) => React.ReactNode;
158-
children?: React.ReactNode;
159155
/**
160156
* Override the default hyphenation-callback
161157
* @see https://react-pdf.org/fonts#registerhyphenationcallback
@@ -202,7 +198,6 @@ declare namespace ReactPDF {
202198
*/
203199
debug?: boolean;
204200
src: string;
205-
children?: React.ReactNode;
206201
}
207202

208203
/**
@@ -215,7 +210,7 @@ declare namespace ReactPDF {
215210
children: string;
216211
}
217212

218-
class Note extends React.Component<React.PropsWithChildren<NoteProps>> {}
213+
class Note extends React.Component<NoteProps> {}
219214

220215
interface CanvasProps extends NodeProps {
221216
/**
@@ -230,7 +225,7 @@ declare namespace ReactPDF {
230225
) => null;
231226
}
232227

233-
class Canvas extends React.Component<React.PropsWithChildren<CanvasProps>> {}
228+
class Canvas extends React.Component<CanvasProps> {}
234229

235230
interface SVGProps extends NodeProps {
236231
/**
@@ -425,7 +420,7 @@ declare namespace ReactPDF {
425420
* @see https://react-pdf.org/advanced#on-the-fly-rendering
426421
* @platform web
427422
*/
428-
class BlobProvider extends React.Component<React.PropsWithChildren<BlobProviderProps>> {}
423+
class BlobProvider extends React.Component<BlobProviderProps> {}
429424

430425
interface PDFViewerProps {
431426
width?: number | string;
@@ -441,7 +436,7 @@ declare namespace ReactPDF {
441436
* Iframe PDF viewer for client-side generated documents.
442437
* @platform web
443438
*/
444-
class PDFViewer extends React.Component<React.PropsWithChildren<PDFViewerProps>> {}
439+
class PDFViewer extends React.Component<PDFViewerProps> {}
445440

446441
interface PDFDownloadLinkProps {
447442
document: React.ReactElement<DocumentProps>;
@@ -459,7 +454,7 @@ declare namespace ReactPDF {
459454
* @see https://react-pdf.org/advanced#on-the-fly-rendering
460455
* @platform web
461456
*/
462-
class PDFDownloadLink extends React.Component<React.PropsWithChildren<PDFDownloadLinkProps>> {}
457+
class PDFDownloadLink extends React.Component<PDFDownloadLinkProps> {}
463458

464459
interface UsePDFInstance {
465460
loading: boolean;

0 commit comments

Comments
 (0)