fix: recognize uppercase environment variables - DIA-37058 (#40)

Fix #39

Author: hadrien

fastapi_sqla/__init__.py

@@ -61,7 +61,8 @@ def setup(app: FastAPI):
 
 
 def startup():
-    engine = engine_from_config(os.environ, prefix="sqlalchemy_")
+    lowercase_environ = {k.lower(): v for k, v in os.environ.items()}
+    engine = engine_from_config(lowercase_environ, prefix="sqlalchemy_")
     Base.metadata.bind = engine
     Base.prepare(engine)
     _Session.configure(bind=engine)

fastapi_sqla/_pytest_plugin.py

@@ -76,11 +76,15 @@ def sqla_reflection(sqla_modules, sqla_connection, db_url):
 
 
 @fixture(autouse=True)
-def patch_sessionmaker(db_url, sqla_connection, sqla_transaction):
+def engine_from_config(request, db_url, sqla_connection, sqla_transaction):
     """So that all DB operations are never written to db for real."""
-    with patch("fastapi_sqla.engine_from_config") as engine_from_config:
-        engine_from_config.return_value = sqla_connection
-        yield engine_from_config
+    if "dont_patch_engine_from_config" in request.keywords:
+        yield
+
+    else:
+        with patch("fastapi_sqla.engine_from_config") as engine_from_config:
+            engine_from_config.return_value = sqla_connection
+            yield engine_from_config
 
 
 @fixture

setup.cfg

@@ -4,7 +4,6 @@ norecursedirs = .git,.venv
 xfail_strict = true
 addopts =
     -p no:fastapi-sqla
-    --strict-markers
     --cov-config setup.cfg
     --cov-report term
     --cov-report term-missing

tests/test_startup.py

@@ -1,11 +1,23 @@
+from unittest.mock import patch
+
 import httpx
 from asgi_lifespan import LifespanManager
 from fastapi import FastAPI
-from pytest import mark
+from pytest import fixture, mark
 from sqlalchemy import text
 
 
-def test_startup():
+@fixture(params=[True, False])
+def case_sensitive_environ(environ, request):
+    values = (
+        {k.upper(): v for k, v in environ.items()} if request.param else environ.copy()
+    )
+    with patch.dict("os.environ", values=values, clear=True):
+        yield values
+
+
+@mark.dont_patch_engine_from_config
+def test_startup(case_sensitive_environ):
     from fastapi_sqla import _Session, startup
 
     startup()