Skip to content

Commit a518114

Browse files
authored
chore: update tarpc comment (#11127)
We forked tarpc to bump opentelemetry crates. This change is now included upstream but we keep using the fork, because upstream switched to syn 3 (which we'll upgrade to after we've gotten rid of syn 1). This updates the rationale in the manifests.
1 parent a3c4f79 commit a518114

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

bazel/rust.MODULE.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1718,6 +1718,7 @@ crate.spec(
17181718
features = [
17191719
"full",
17201720
],
1721+
# Pinned to a fork because the published `tarpc` uses syn 3, while the rest of this repo (still) uses syn 2.
17211722
git = "https://github.com/dfinity/tarpc",
17221723
package = "tarpc",
17231724
rev = "cddf1c64011d00f36016146e8447bef99531030c",

rs/crypto/internal/crypto_service_provider/Cargo.toml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,7 @@ slog = { workspace = true }
5252
strum = { workspace = true }
5353
strum_macros = { workspace = true }
5454
stubborn-io = "0.3.2"
55-
# Pinned to a fork because the published `tarpc` releases lag well behind on
56-
# `opentelemetry`. Switch back to crates.io once this is released:
57-
# https://github.com/google/tarpc/pull/565
55+
# Pinned to a fork because the published `tarpc` uses syn 3, while the rest of this repo (still) uses syn 2.
5856
tarpc = { git = "https://github.com/dfinity/tarpc", rev = "cddf1c64011d00f36016146e8447bef99531030c", features = [
5957
"full",
6058
] }

0 commit comments

Comments
 (0)