Commit 81762e4
chore: mark action bundles as generated and cover extract-version
The four JavaScript actions run from a committed dist/index.js, so every runtime
dependency is bundled into it. That puts large generated artifacts in the middle
of every review: #79 changed 28 lines of package.json and pnpm-lock.yaml plus
3,176 lines of rebuilt bundle, so 99% of that review was generated output.
Marks them as generated in .gitattributes so they collapse in pull request
diffs. Reviewers see the source changes, and check_dist:required continues to
guarantee that the collapsed output is exactly what that source compiles to,
which is what makes collapsing it safe rather than reckless.
Adds extract-version to the check_dist matrix. It is a node24 action with an
856K bundle that was not covered, so a stale bundle there went unverified, and
it is the action release workflows use to read the version being published. Its
committed bundle is currently in sync, so this adds coverage without requiring
a rebuild.
Documents both in CONTRIBUTING.md, including the part that is easy to miss: a
dependency fix without rebuilt bundles does not change what runs, because the
lockfile is not consulted when GitHub executes an action. Adds a matching
convention to the README, since this repo documents conventions for other
repositories too.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 7d3dfd9 commit 81762e4
4 files changed
Lines changed: 30 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
52 | 64 | | |
53 | 65 | | |
54 | 66 | | |
| |||
0 commit comments